components/policy/core/common/cloud/external_policy_data_updater_unittest.cc - Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

Issue 1902633006: Convert //components/policy from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments and use namespace alias Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/external_policy_data_updater.cc ('k') | components/policy/core/common/cloud/mock_cloud_external_data_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

diff --git a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

index 977e26045a3c6168eb915a60bfa6bccf02626634..6dc51abf780c5d328198ace36db1a14fe31df0d2 100644

--- a/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

+++ b/components/policy/core/common/cloud/external_policy_data_updater_unittest.cc

@@ -7,11 +7,12 @@

#include <stddef.h>

#include <stdint.h>

+#include <memory>

#include "base/bind.h"

#include "base/bind_helpers.h"

#include "base/callback.h"

#include "base/compiler_specific.h"

-#include "base/memory/scoped_ptr.h"

#include "base/test/test_pending_task.h"

#include "base/test/test_simple_task_runner.h"

#include "base/time/time.h"

@@ -74,8 +75,8 @@ class ExternalPolicyDataUpdaterTest : public testing::Test {

MockFetchSuccessCallbackListener callback_listener_;

scoped_refptr<base::TestSimpleTaskRunner> backend_task_runner_;

scoped_refptr<base::TestSimpleTaskRunner> io_task_runner_;

- scoped_ptr<ExternalPolicyDataFetcherBackend> fetcher_backend_;

- scoped_ptr<ExternalPolicyDataUpdater> updater_;

+ std::unique_ptr<ExternalPolicyDataFetcherBackend> fetcher_backend_;

+ std::unique_ptr<ExternalPolicyDataUpdater> updater_;

};

void ExternalPolicyDataUpdaterTest::SetUp() {