Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 18836004: Move ICU headers from public/{common,i18n} to source/{common,i18n} (Closed)

Created:
7 years, 5 months ago by jungshik at Google
Modified:
7 years, 5 months ago
CC:
darin (slow to review), Nebojša Ćirić, Paweł Hajdan Jr., tony, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Move ICU headers from public/{common,i18n} to source/{common,i18n} The upstream has headers in source/{common,i18n}/unicode. With Blink's ICU headers removed, there's no need to keep them in a location different than the upstream. Future ICU updates will be a bit more streamlined. v8 also likes to have this change. The Chrome-side of change is at http://codereview.chromium.org/18252003 This revision will be rolled in along with the global replacements of include-references to ICU headers and DEPS changes. See also http://crbug.com/232922 where ICU headers in Blink are removed. Landed in 3 steps: http://crrev.com/211838 http://crrev.com/211848 http://crrev.com/211851 BUG=251433 TEST=NONE for now.

Patch Set 1 #

Patch Set 2 : icu.gyp update added #

Patch Set 3 : do not prepend icu header any more #

Patch Set 4 : same as ps #3. retry uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-145 lines, -89005 lines) Patch
M icu.gyp View 1 2 3 5 chunks +10 lines, -26 lines 0 comments Download
D public/common/unicode/brkiter.h View 1 2 3 1 chunk +0 lines, -557 lines 0 comments Download
D public/common/unicode/bytestream.h View 1 2 3 1 chunk +0 lines, -252 lines 0 comments Download
D public/common/unicode/caniter.h View 1 2 3 1 chunk +0 lines, -206 lines 0 comments Download
D public/common/unicode/chariter.h View 1 2 3 1 chunk +0 lines, -716 lines 0 comments Download
D public/common/unicode/dbbi.h View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D public/common/unicode/docmain.h View 1 2 3 1 chunk +0 lines, -207 lines 0 comments Download
D public/common/unicode/dtintrv.h View 1 2 3 1 chunk +0 lines, -158 lines 0 comments Download
D public/common/unicode/errorcode.h View 1 2 3 1 chunk +0 lines, -137 lines 0 comments Download
D public/common/unicode/icudataver.h View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D public/common/unicode/icuplug.h View 1 2 3 1 chunk +0 lines, -370 lines 0 comments Download
D public/common/unicode/idna.h View 1 2 3 1 chunk +0 lines, -321 lines 0 comments Download
D public/common/unicode/localpointer.h View 1 2 3 1 chunk +0 lines, -300 lines 0 comments Download
D public/common/unicode/locid.h View 1 2 3 1 chunk +0 lines, -781 lines 0 comments Download
D public/common/unicode/normalizer2.h View 1 2 3 1 chunk +0 lines, -482 lines 0 comments Download
D public/common/unicode/normlzr.h View 1 2 3 1 chunk +0 lines, -797 lines 0 comments Download
D public/common/unicode/pandroid.h View 1 2 3 1 chunk +0 lines, -403 lines 0 comments Download
D public/common/unicode/parseerr.h View 1 2 3 1 chunk +0 lines, -92 lines 0 comments Download
D public/common/unicode/parsepos.h View 1 2 3 1 chunk +0 lines, -230 lines 0 comments Download
D public/common/unicode/pfreebsd.h View 1 2 3 1 chunk +0 lines, -401 lines 0 comments Download
D public/common/unicode/platform.h.in View 1 2 3 1 chunk +0 lines, -403 lines 0 comments Download
D public/common/unicode/plinux.h View 1 2 3 1 chunk +0 lines, -403 lines 0 comments Download
D public/common/unicode/pmac.h View 1 2 3 1 chunk +0 lines, -439 lines 0 comments Download
D public/common/unicode/popenbsd.h View 1 2 3 1 chunk +0 lines, -313 lines 0 comments Download
D public/common/unicode/ppalmos.h View 1 2 3 1 chunk +0 lines, -273 lines 0 comments Download
D public/common/unicode/ptypes.h View 1 2 3 1 chunk +0 lines, -103 lines 0 comments Download
D public/common/unicode/putil.h View 1 2 3 1 chunk +0 lines, -193 lines 0 comments Download
D public/common/unicode/pwin32.h View 1 2 3 1 chunk +0 lines, -376 lines 0 comments Download
D public/common/unicode/rbbi.h View 1 2 3 1 chunk +0 lines, -722 lines 0 comments Download
D public/common/unicode/rep.h View 1 2 3 1 chunk +0 lines, -259 lines 0 comments Download
D public/common/unicode/resbund.h View 1 2 3 1 chunk +0 lines, -485 lines 0 comments Download
D public/common/unicode/schriter.h View 1 2 3 1 chunk +0 lines, -187 lines 0 comments Download
D public/common/unicode/std_string.h View 1 2 3 1 chunk +0 lines, -78 lines 0 comments Download
D public/common/unicode/strenum.h View 1 2 3 1 chunk +0 lines, -271 lines 0 comments Download
D public/common/unicode/stringpiece.h View 1 2 3 1 chunk +0 lines, -224 lines 0 comments Download
D public/common/unicode/symtable.h View 1 2 3 1 chunk +0 lines, -112 lines 0 comments Download
D public/common/unicode/ubidi.h View 1 2 3 1 chunk +0 lines, -2096 lines 0 comments Download
D public/common/unicode/ubrk.h View 1 2 3 1 chunk +0 lines, -501 lines 0 comments Download
D public/common/unicode/ucasemap.h View 1 2 3 1 chunk +0 lines, -421 lines 0 comments Download
D public/common/unicode/ucat.h View 1 2 3 1 chunk +0 lines, -158 lines 0 comments Download
D public/common/unicode/uchar.h View 1 2 3 1 chunk +0 lines, -3168 lines 0 comments Download
D public/common/unicode/uchriter.h View 1 2 3 1 chunk +0 lines, -381 lines 0 comments Download
D public/common/unicode/uclean.h View 1 2 3 1 chunk +0 lines, -251 lines 0 comments Download
D public/common/unicode/ucnv.h View 1 2 3 1 chunk +0 lines, -1997 lines 0 comments Download
D public/common/unicode/ucnv_cb.h View 1 2 3 1 chunk +0 lines, -162 lines 0 comments Download
D public/common/unicode/ucnv_err.h View 1 2 3 1 chunk +0 lines, -463 lines 0 comments Download
D public/common/unicode/ucnvsel.h View 1 2 3 1 chunk +0 lines, -182 lines 0 comments Download
D public/common/unicode/uconfig.h View 1 2 3 1 chunk +0 lines, -231 lines 0 comments Download
D public/common/unicode/udata.h View 1 2 3 1 chunk +0 lines, -415 lines 0 comments Download
D public/common/unicode/udeprctd.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D public/common/unicode/udraft.h View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D public/common/unicode/uenum.h View 1 2 3 1 chunk +0 lines, -174 lines 0 comments Download
D public/common/unicode/uidna.h View 1 2 3 1 chunk +0 lines, -733 lines 0 comments Download
D public/common/unicode/uintrnal.h View 1 2 3 1 chunk +0 lines, -252 lines 0 comments Download
D public/common/unicode/uiter.h View 1 2 3 1 chunk +0 lines, -707 lines 0 comments Download
D public/common/unicode/uloc.h View 1 2 3 1 chunk +0 lines, -1126 lines 0 comments Download
D public/common/unicode/umachine.h View 1 2 3 1 chunk +0 lines, -374 lines 0 comments Download
D public/common/unicode/umisc.h View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download
D public/common/unicode/unifilt.h View 1 2 3 1 chunk +0 lines, -120 lines 0 comments Download
D public/common/unicode/unifunct.h View 1 2 3 1 chunk +0 lines, -125 lines 0 comments Download
D public/common/unicode/unimatch.h View 1 2 3 1 chunk +0 lines, -163 lines 0 comments Download
D public/common/unicode/uniset.h View 1 2 3 1 chunk +0 lines, -1673 lines 0 comments Download
D public/common/unicode/unistr.h View 1 2 3 1 chunk +0 lines, -4448 lines 0 comments Download
D public/common/unicode/unorm.h View 1 2 3 1 chunk +0 lines, -561 lines 0 comments Download
D public/common/unicode/unorm2.h View 1 2 3 1 chunk +0 lines, -391 lines 0 comments Download
D public/common/unicode/uobject.h View 1 2 3 1 chunk +0 lines, -352 lines 0 comments Download
D public/common/unicode/uobslete.h View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D public/common/unicode/urename.h View 1 2 3 1 chunk +0 lines, -2241 lines 0 comments Download
D public/common/unicode/urep.h View 1 2 3 1 chunk +0 lines, -155 lines 0 comments Download
D public/common/unicode/ures.h View 1 2 3 1 chunk +0 lines, -879 lines 0 comments Download
D public/common/unicode/uscript.h View 1 2 3 1 chunk +0 lines, -326 lines 0 comments Download
D public/common/unicode/uset.h View 1 2 3 1 chunk +0 lines, -1120 lines 0 comments Download
D public/common/unicode/usetiter.h View 1 2 3 1 chunk +0 lines, -318 lines 0 comments Download
D public/common/unicode/ushape.h View 1 2 3 1 chunk +0 lines, -474 lines 0 comments Download
D public/common/unicode/usprep.h View 1 2 3 1 chunk +0 lines, -269 lines 0 comments Download
D public/common/unicode/ustring.h View 1 2 3 1 chunk +0 lines, -1696 lines 0 comments Download
D public/common/unicode/usystem.h View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
D public/common/unicode/utext.h View 1 2 3 1 chunk +0 lines, -1737 lines 0 comments Download
D public/common/unicode/utf.h View 1 2 3 1 chunk +0 lines, -236 lines 0 comments Download
D public/common/unicode/utf16.h View 1 2 3 1 chunk +0 lines, -614 lines 0 comments Download
D public/common/unicode/utf32.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D public/common/unicode/utf8.h View 1 2 3 1 chunk +0 lines, -683 lines 0 comments Download
D public/common/unicode/utf_old.h View 1 2 3 1 chunk +0 lines, -1173 lines 0 comments Download
D public/common/unicode/utrace.h View 1 2 3 1 chunk +0 lines, -358 lines 0 comments Download
D public/common/unicode/utypeinfo.h View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
D public/common/unicode/utypes.h View 1 2 3 1 chunk +0 lines, -865 lines 0 comments Download
D public/common/unicode/uvernum.h View 1 2 3 1 chunk +0 lines, -151 lines 0 comments Download
D public/common/unicode/uversion.h View 1 2 3 1 chunk +0 lines, -195 lines 0 comments Download
D public/i18n/unicode/basictz.h View 1 2 3 1 chunk +0 lines, -210 lines 0 comments Download
D public/i18n/unicode/bms.h View 1 2 3 1 chunk +0 lines, -274 lines 0 comments Download
D public/i18n/unicode/bmsearch.h View 1 2 3 1 chunk +0 lines, -226 lines 0 comments Download
D public/i18n/unicode/calendar.h View 1 2 3 1 chunk +0 lines, -2252 lines 0 comments Download
D public/i18n/unicode/choicfmt.h View 1 2 3 1 chunk +0 lines, -749 lines 0 comments Download
D public/i18n/unicode/coleitr.h View 1 2 3 1 chunk +0 lines, -400 lines 0 comments Download
D public/i18n/unicode/coll.h View 1 2 3 1 chunk +0 lines, -1113 lines 0 comments Download
D public/i18n/unicode/colldata.h View 1 2 3 1 chunk +0 lines, -452 lines 0 comments Download
D public/i18n/unicode/curramt.h View 1 2 3 1 chunk +0 lines, -130 lines 0 comments Download
D public/i18n/unicode/currpinf.h View 1 2 3 1 chunk +0 lines, -259 lines 0 comments Download
D public/i18n/unicode/currunit.h View 1 2 3 1 chunk +0 lines, -117 lines 0 comments Download
D public/i18n/unicode/datefmt.h View 1 2 3 1 chunk +0 lines, -751 lines 0 comments Download
D public/i18n/unicode/dcfmtsym.h View 1 2 3 1 chunk +0 lines, -460 lines 0 comments Download
D public/i18n/unicode/decimfmt.h View 1 2 3 1 chunk +0 lines, -2310 lines 0 comments Download
D public/i18n/unicode/dtfmtsym.h View 1 2 3 1 chunk +0 lines, -755 lines 0 comments Download
D public/i18n/unicode/dtitvfmt.h View 1 2 3 1 chunk +0 lines, -970 lines 0 comments Download
D public/i18n/unicode/dtitvinf.h View 1 2 3 1 chunk +0 lines, -527 lines 0 comments Download
D public/i18n/unicode/dtptngen.h View 1 2 3 1 chunk +0 lines, -474 lines 0 comments Download
D public/i18n/unicode/dtrule.h View 1 2 3 1 chunk +0 lines, -250 lines 0 comments Download
D public/i18n/unicode/fieldpos.h View 1 2 3 1 chunk +0 lines, -291 lines 0 comments Download
D public/i18n/unicode/fmtable.h View 1 2 3 1 chunk +0 lines, -673 lines 0 comments Download
D public/i18n/unicode/format.h View 1 2 3 1 chunk +0 lines, -303 lines 0 comments Download
D public/i18n/unicode/fpositer.h View 1 2 3 1 chunk +0 lines, -120 lines 0 comments Download
D public/i18n/unicode/gregocal.h View 1 2 3 1 chunk +0 lines, -823 lines 0 comments Download
D public/i18n/unicode/locdspnm.h View 1 2 3 1 chunk +0 lines, -188 lines 0 comments Download
D public/i18n/unicode/measfmt.h View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
D public/i18n/unicode/measunit.h View 1 2 3 1 chunk +0 lines, -71 lines 0 comments Download
D public/i18n/unicode/measure.h View 1 2 3 1 chunk +0 lines, -137 lines 0 comments Download
D public/i18n/unicode/msgfmt.h View 1 2 3 1 chunk +0 lines, -961 lines 0 comments Download
D public/i18n/unicode/numfmt.h View 1 2 3 1 chunk +0 lines, -1051 lines 0 comments Download
D public/i18n/unicode/numsys.h View 1 2 3 1 chunk +0 lines, -191 lines 0 comments Download
D public/i18n/unicode/plurfmt.h View 1 2 3 1 chunk +0 lines, -549 lines 0 comments Download
D public/i18n/unicode/plurrule.h View 1 2 3 1 chunk +0 lines, -299 lines 0 comments Download
D public/i18n/unicode/rbnf.h View 1 2 3 1 chunk +0 lines, -1059 lines 0 comments Download
D public/i18n/unicode/rbtz.h View 1 2 3 1 chunk +0 lines, -361 lines 0 comments Download
D public/i18n/unicode/regex.h View 1 2 3 1 chunk +0 lines, -1772 lines 0 comments Download
D public/i18n/unicode/search.h View 1 2 3 1 chunk +0 lines, -569 lines 0 comments Download
D public/i18n/unicode/selfmt.h View 1 2 3 1 chunk +0 lines, -377 lines 0 comments Download
D public/i18n/unicode/simpletz.h View 1 2 3 1 chunk +0 lines, -927 lines 0 comments Download
D public/i18n/unicode/smpdtfmt.h View 1 2 3 1 chunk +0 lines, -1207 lines 0 comments Download
D public/i18n/unicode/sortkey.h View 1 2 3 1 chunk +0 lines, -324 lines 0 comments Download
D public/i18n/unicode/stsearch.h View 1 2 3 1 chunk +0 lines, -518 lines 0 comments Download
D public/i18n/unicode/tblcoll.h View 1 2 3 1 chunk +0 lines, -966 lines 0 comments Download
D public/i18n/unicode/timezone.h View 1 2 3 1 chunk +0 lines, -777 lines 0 comments Download
D public/i18n/unicode/tmunit.h View 1 2 3 1 chunk +0 lines, -149 lines 0 comments Download
D public/i18n/unicode/tmutamt.h View 1 2 3 1 chunk +0 lines, -168 lines 0 comments Download
D public/i18n/unicode/tmutfmt.h View 1 2 3 1 chunk +0 lines, -272 lines 0 comments Download
D public/i18n/unicode/translit.h View 1 2 3 1 chunk +0 lines, -1320 lines 0 comments Download
D public/i18n/unicode/tzrule.h View 1 2 3 1 chunk +0 lines, -828 lines 0 comments Download
D public/i18n/unicode/tztrans.h View 1 2 3 1 chunk +0 lines, -195 lines 0 comments Download
D public/i18n/unicode/ucal.h View 1 2 3 1 chunk +0 lines, -1285 lines 0 comments Download
D public/i18n/unicode/ucol.h View 1 2 3 1 chunk +0 lines, -1227 lines 0 comments Download
D public/i18n/unicode/ucoleitr.h View 1 2 3 1 chunk +0 lines, -330 lines 0 comments Download
D public/i18n/unicode/ucsdet.h View 1 2 3 1 chunk +0 lines, -370 lines 0 comments Download
D public/i18n/unicode/ucurr.h View 1 2 3 1 chunk +0 lines, -316 lines 0 comments Download
D public/i18n/unicode/udat.h View 1 2 3 1 chunk +0 lines, -997 lines 0 comments Download
D public/i18n/unicode/udatpg.h View 1 2 3 1 chunk +0 lines, -586 lines 0 comments Download
D public/i18n/unicode/uldnames.h View 1 2 3 1 chunk +0 lines, -270 lines 0 comments Download
D public/i18n/unicode/ulocdata.h View 1 2 3 1 chunk +0 lines, -263 lines 0 comments Download
D public/i18n/unicode/umsg.h View 1 2 3 1 chunk +0 lines, -709 lines 0 comments Download
D public/i18n/unicode/unirepl.h View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
D public/i18n/unicode/unum.h View 1 2 3 1 chunk +0 lines, -999 lines 0 comments Download
D public/i18n/unicode/uregex.h View 1 2 3 1 chunk +0 lines, -1451 lines 0 comments Download
D public/i18n/unicode/usearch.h View 1 2 3 1 chunk +0 lines, -829 lines 0 comments Download
D public/i18n/unicode/uspoof.h View 1 2 3 1 chunk +0 lines, -887 lines 0 comments Download
D public/i18n/unicode/utmscale.h View 1 2 3 1 chunk +0 lines, -481 lines 0 comments Download
D public/i18n/unicode/utrans.h View 1 2 3 1 chunk +0 lines, -603 lines 0 comments Download
D public/i18n/unicode/vtzone.h View 1 2 3 1 chunk +0 lines, -455 lines 0 comments Download
A + source/common/unicode/brkiter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/bytestream.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/caniter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/chariter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/dbbi.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/docmain.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/dtintrv.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/errorcode.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/icudataver.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/icuplug.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/idna.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/localpointer.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/locid.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/normalizer2.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/normlzr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/pandroid.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/parseerr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/parsepos.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/pfreebsd.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/platform.h.in View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/plinux.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/pmac.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/popenbsd.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ppalmos.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ptypes.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/putil.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/pwin32.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/rbbi.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/rep.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/resbund.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/schriter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/std_string.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/strenum.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/stringpiece.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/symtable.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ubidi.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ubrk.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucasemap.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucat.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uchar.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uchriter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uclean.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucnv.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucnv_cb.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucnv_err.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ucnvsel.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uconfig.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/udata.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/udeprctd.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/udraft.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uenum.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uidna.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uintrnal.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uiter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uloc.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/umachine.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/umisc.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unifilt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unifunct.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unimatch.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uniset.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unistr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unorm.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/unorm2.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uobject.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uobslete.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/urename.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/urep.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ures.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uscript.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uset.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/usetiter.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ushape.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/usprep.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/ustring.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/usystem.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utext.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utf.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utf16.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utf32.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utf8.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utf_old.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utrace.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utypeinfo.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/utypes.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uvernum.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/common/unicode/uversion.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/basictz.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/bms.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/bmsearch.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/calendar.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/choicfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/coleitr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/coll.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/colldata.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/curramt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/currpinf.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/currunit.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/datefmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dcfmtsym.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/decimfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dtfmtsym.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dtitvfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dtitvinf.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dtptngen.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/dtrule.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/fieldpos.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/fmtable.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/format.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/fpositer.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/gregocal.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/locdspnm.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/measfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/measunit.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/measure.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/msgfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/numfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/numsys.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/plurfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/plurrule.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/rbnf.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/rbtz.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/regex.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/search.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/selfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/simpletz.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/smpdtfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/sortkey.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/stsearch.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tblcoll.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/timezone.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tmunit.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tmutamt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tmutfmt.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/translit.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tzrule.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/tztrans.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ucal.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ucol.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ucoleitr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ucsdet.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ucurr.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/udat.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/udatpg.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/uldnames.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/ulocdata.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/umsg.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/unirepl.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/unum.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/uregex.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/usearch.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/uspoof.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/utmscale.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/utrans.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + source/i18n/unicode/vtzone.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jungshik at Google
Mark, please see if there's anything wrong with icu.gyp changes. Other changes are just moving ...
7 years, 5 months ago (2013-07-14 06:52:28 UTC) #1
Xianzhu
On 2013/07/14 06:52:28, Jungshik Shin wrote: > Xianzhu, do you have any concern for Android? ...
7 years, 5 months ago (2013-07-15 16:41:04 UTC) #2
Mark Mentovai
icu.gyp looks fine. LGTM.
7 years, 5 months ago (2013-07-15 16:42:25 UTC) #3
Torne
use_system_icu stuff looks reasonable. LGTM.
7 years, 5 months ago (2013-07-15 16:52:35 UTC) #4
Torne
On 2013/07/15 16:52:35, Torne wrote: > use_system_icu stuff looks reasonable. LGTM. Er, though actually, we ...
7 years, 5 months ago (2013-07-15 16:53:11 UTC) #5
jungshik at Google
On 2013/07/15 16:53:11, Torne wrote: > On 2013/07/15 16:52:35, Torne wrote: > > use_system_icu stuff ...
7 years, 5 months ago (2013-07-15 19:05:12 UTC) #6
jungshik at Google
CQ hasn't picked up this CL (because it's in svn but I used a git ...
7 years, 5 months ago (2013-07-16 18:55:58 UTC) #7
jungshik at Google
7 years, 5 months ago (2013-07-16 22:27:24 UTC) #8
Message was sent while issue was closed.
Landed in 3 steps as noted in the CL description. 

On 2013/07/16 18:55:58, Jungshik Shin wrote:
> CQ hasn't picked up this CL (because it's in svn but I used a git client?).
I'll
> try to land manually (git cl dcommit does not work, either). I'll have to copy
> the CL to a svn client and land manually. 
> 
> 
> On 2013/07/15 19:05:12, Jungshik Shin wrote:
> > On 2013/07/15 16:53:11, Torne wrote:
> > > On 2013/07/15 16:52:35, Torne wrote:
> > > > use_system_icu stuff looks reasonable. LGTM.
> > > 
> > > Er, though actually, we now have an optional trybot for the android
webview
> > > config: run a try job on "android_aosp" for the CL and it should prove it
> > works.
> > 
> > Thank you for the review, Mark and Torne. The next CL on th Chrome-side (
> > http://codereview.chromium.org/18252003 ) will bring in this change and I'll
> > make sure to run android_aosp bot.

Powered by Google App Engine
This is Rietveld 408576698