[Findit] A huge refactoring and some bug fixing.

[Findit] A huge refactoring and some bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead code there.
4. Use constants and remove scattered hard-coded strings for queue names, module names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
Committed: https://chromium.googlesource.com/infra/infra/+/b72a1b8cd1f0d3429ae8e781126596c4242ff23c

[stgao, 2016-04-07 00:17:20]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

BUG=
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to force USER name as version for testing
deployment and make it possible to deploy to prod for staging testing.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

[stgao, 2016-04-07 00:17:20]

stgao@chromium.org changed reviewers:
+ lijeffrey@chromium.org

[stgao, 2016-04-07 00:17:34]

ptal

[stgao, 2016-04-07 00:18:42]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to force USER name as version for testing
deployment and make it possible to deploy to prod for staging testing.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to force USER name as version for testing
deployment and make it possible to deploy to prod for staging testing.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

[stgao, 2016-04-07 00:20:08]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to force USER name as version for testing
deployment and make it possible to deploy to prod for staging testing.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

[stgao, 2016-04-07 00:20:53]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

[stgao, 2016-04-07 00:22:04]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

[stgao, 2016-04-07 00:22:32]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

to

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

[stgao, 2016-04-07 00:22:48]

Description was changed from

==========
[Findit] A huge refactoring and lots of bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

to

==========
[Findit] A huge refactoring and some bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

[lijeffrey, 2016-04-07 02:57:30]

lgtm

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/queue.yaml
File appengine/findit/queue.yaml (left):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/queue.yaml...
appengine/findit/queue.yaml:26: min_backoff_seconds: 5
Is this not needed anymore?

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/run.sh (right):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/run.sh:18: echo "Can't not identify who is
deploying Findit. Please set USER."
nit: Cannot identify who is deploying Findit ...

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/try_job_util.py (left):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/try_job_util.py:17: # TODO(chanli): Need to figure
out why try-job-queue doesn't work.
Does this comment still apply? If so maybe mve this TODO to where
constants.WATERFALL_TRY_JOB_QUEUE is being used near line 173

[stgao, 2016-04-07 04:46:04]

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/queue.yaml
File appengine/findit/queue.yaml (left):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/queue.yaml...
appengine/findit/queue.yaml:26: min_backoff_seconds: 5
On 2016/04/07 02:57:30, lijeffrey wrote:
> Is this not needed anymore?

No. Because the retry_limit is zero, this one has no effects.

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/run.sh (right):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/run.sh:18: echo "Can't not identify who is
deploying Findit. Please set USER."
On 2016/04/07 02:57:30, lijeffrey wrote:
> nit: Cannot identify who is deploying Findit ...

Done.

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/try_job_util.py (left):

https://codereview.chromium.org/1866883002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/try_job_util.py:17: # TODO(chanli): Need to figure
out why try-job-queue doesn't work.
On 2016/04/07 02:57:30, lijeffrey wrote:
> Does this comment still apply? If so maybe mve this TODO to where
> constants.WATERFALL_TRY_JOB_QUEUE is being used near line 173

No. The problem was already fixed.

[stgao, 2016-04-07 04:46:13]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-04-07 04:46:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/1866883002/#ps20001
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-04-07 04:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866883002/20001

[commit-bot: I haz the power, 2016-04-07 06:31:14]

Description was changed from

==========
[Findit] A huge refactoring and some bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460
==========

to

==========
[Findit] A huge refactoring and some bug fixing.

The refactoring is a preparation to merge Findit for ClusterFuzz into the
findit-for-me app and for the integration with Fracas.

Refacoring includes:
1. Separate the waterfall-frontend from the default module.
2. Use dispatch to route requests to the appropriate modules.
3. Refactor wf_analysis_result_status and wf_analysis_status and removed dead
code there.
4. Use constants and remove scattered hard-coded strings for queue names, module
names, and urls.
5. Setup new task queues with clear names.
6. Use a new app id for testing findit-for-me-dev.

Functional change:
1. Update util_scripts/run.sh to:
   * Enforce USER name as version for testing deployment
   * Make it possible to deploy to prod for staging testing
   * Provide commands to update task queue, cron job, and dispatch
2. Add links to step log back to build_failure.html page.

Bug fixing:
1. Fix versioned_model when no entity is available yet.
2. Fix a bug in handlers/handlers_util.py


BUG=600460

Committed:
https://chromium.googlesource.com/infra/infra/+/b72a1b8cd1f0d3429ae8e78112659...
==========

[commit-bot: I haz the power, 2016-04-07 06:31:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/b72a1b8cd1f0d3429ae8e78112659...