Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: appengine/findit/handlers/handlers_util.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/check_duplicate_failures.py ('k') | appengine/findit/handlers/list_analyses.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/handlers_util.py
diff --git a/appengine/findit/handlers/handlers_util.py b/appengine/findit/handlers/handlers_util.py
index fe3b67e872e411b739a8285f5c51c0a2a9954728..e8194774cca0127a77033ce10e217c5a9187c28c 100644
--- a/appengine/findit/handlers/handlers_util.py
+++ b/appengine/findit/handlers/handlers_util.py
@@ -6,7 +6,7 @@ from collections import defaultdict
import copy
from handlers import result_status
-from model import wf_analysis_status
+from model import analysis_status
from model.wf_analysis import WfAnalysis
from model.wf_swarming_task import WfSwarmingTask
from model.wf_try_job import WfTryJob
@@ -298,7 +298,7 @@ def _UpdateTryJobInfoBasedOnSwarming(step_tasks_info, try_jobs):
try_job_key = try_job['try_job_key']
task = step_tasks_info.get('swarming_tasks', {}).get(try_job_key)
- if task['task_info']['status'] != wf_analysis_status.ANALYZED:
+ if task['task_info']['status'] != analysis_status.COMPLETED:
# There is someting wrong with swarming task or it's not done yet,
# no try job yet or ever.
try_job['status'] = result_status.NO_TRY_JOB_REASON_MAP[
@@ -347,7 +347,7 @@ def _GetAllTryJobResultsForTest(failure_result_map, tasks_info):
}
try_jobs.append(try_job_dict)
step_try_job_keys.add(try_job_key)
- try_job_keys.update(step_try_job_keys)
+ try_job_keys.update(step_try_job_keys)
else:
# Try job should only be triggered for swarming tests, because we cannot
# identify flaky tests for non-swarming tests.
« no previous file with comments | « appengine/findit/handlers/check_duplicate_failures.py ('k') | appengine/findit/handlers/list_analyses.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698