appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py - Issue 1866883002: [Findit] A huge refactoring and some bug fixing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fix nit. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/run_try_job_for_reliable_failure_pipeline_test.py ('k') | appengine/findit/waterfall/test/try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py b/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

index 0ec24b0b9b29292f6cb4b3d5d0820fba6c5ef5f9..7178d7df84a12856bd3a6888d8bc0bad0f46e422 100644

--- a/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

+++ b/appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py

@@ -4,7 +4,7 @@

import time

-from model import wf_analysis_status

+from model import analysis_status

from model.wf_swarming_task import WfSwarmingTask

from waterfall import swarming_util

from waterfall import trigger_swarming_task_pipeline

@@ -29,7 +29,7 @@ class TriggerSwarmingTaskPipelineTest(wf_testcase.WaterfallTestCase):

MockedListSwarmingTasksDataByTags)

swarming_task = WfSwarmingTask.Create(

master_name, builder_name, build_number, step_name)

- swarming_task.status = wf_analysis_status.ANALYZING

+ swarming_task.status = analysis_status.RUNNING

swarming_task.task_id = 'task_id'

swarming_task.put()

@@ -47,14 +47,14 @@ class TriggerSwarmingTaskPipelineTest(wf_testcase.WaterfallTestCase):

swarming_task = WfSwarmingTask.Create(

master_name, builder_name, build_number, step_name)

- swarming_task.status = wf_analysis_status.PENDING

+ swarming_task.status = analysis_status.PENDING

swarming_task.put()

def MockedSleep(*_):

swarming_task = WfSwarmingTask.Get(

master_name, builder_name, build_number, step_name)

- self.assertEqual(wf_analysis_status.PENDING, swarming_task.status)

- swarming_task.status = wf_analysis_status.ANALYZING

+ self.assertEqual(analysis_status.PENDING, swarming_task.status)

+ swarming_task.status = analysis_status.RUNNING

swarming_task.task_id = 'task_id'

swarming_task.put()

self.mock(time, 'sleep', MockedSleep)