[Findit] A huge refactoring and some bug fixing.

appengine/findit/handlers/test/build_failure_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 
 from google.appengine.ext import testbed
 
 import webapp2
 import webtest
 
 from handlers import build_failure
 from handlers import handlers_util
 from handlers import result_status
 from model.wf_analysis import WfAnalysis
-from model import wf_analysis_status
+from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 from waterfall.test import wf_testcase
 
 # Root directory appengine/findit.
 ROOT_DIR = os.path.join(os.path.dirname(__file__),
                         os.path.pardir, os.path.pardir)
 
 SAMPLE_TRY_JOB_INFO = {
     'm/b/119': {
         'step1 on platform':{
             'try_jobs': [
                 {
                     'ref_name': 'step1',
                     'try_job_key': 'm/b/119',
                     'task_id': 'task1',
                     'task_url': 'url/task1',
-                    'status': wf_analysis_status.ANALYZED,
+                    'status': analysis_status.COMPLETED,
                     'try_job_url': (
                         'http://build.chromium.org/p/tryserver.chromium.'
                         'linux/builders/linux_variable/builds/121'),
                     'try_job_build_number': 121,
                     'tests': ['test3'],
                     'culprit': {}
                 },
                 {
                     'ref_name': 'step1',
                     'try_job_key': 'm/b/119',
                     'task_id': 'task1',
                     'task_url': 'url/task1',
-                    'status': wf_analysis_status.ANALYZED,
+                    'status': analysis_status.COMPLETED,
                     'try_job_url': (
                         'http://build.chromium.org/p/tryserver.chromium.'
                         'linux/builders/linux_variable/builds/121'),
                     'try_job_build_number': 121,
                     'culprit': {
                         'revision': 'rev2',
                         'commit_position': '2',
                         'review_url': 'url_2'
                     },
                     'tests': ['test2']
                 },
                 {
                     'ref_name': 'step1',
                     'try_job_key': 'm/b/119',
                     'status': result_status.FLAKY,
                     'task_id': 'task1',
                     'task_url': 'url/task1',
                     'tests': ['test4']
                 },
                 {
                     'ref_name': 'step1',
                     'try_job_key': 'm/b/120',
                     'status': result_status.NO_TRY_JOB_REASON_MAP[
-                        wf_analysis_status.PENDING],
+                        analysis_status.PENDING],
                     'task_id': 'task2',
                     'task_url': 'url/task2',
                     'tests': ['test1']
                 }
             ]
         }
     },
     'm/b/120': {
         'compile': {
             'try_jobs': [
                 {
                     'try_job_key': 'm/b/120',
-                    'status': wf_analysis_status.ANALYZED,
+                    'status': analysis_status.COMPLETED,
                     'try_job_build_number': 120,
                     'try_job_url': (
                         'http://build.chromium.org/p/tryserver.chromium.'
                         'linux/builders/linux_variable/builds/120'),
                     'culprit': {
                         'revision': 'rev2',
                         'commit_position': '2',
                         'review_url': 'url_2'
                     }
                 }
@@ skipping 17 matching lines @@
     for queue in self.taskqueue_stub.GetQueues():
       self.taskqueue_stub.FlushQueue(queue['name'])
 
     def MockedGetAllTryJobResults(master_name, builder_name, build_number):
       build_key = '%s/%s/%d' % (master_name, builder_name, build_number)
       return SAMPLE_TRY_JOB_INFO.get(build_key, None)
     self.mock(handlers_util, 'GetAllTryJobResults', MockedGetAllTryJobResults)
 
   def testGetTriageHistoryWhenUserIsNotAdmin(self):
     analysis = WfAnalysis.Create('m', 'b', 1)
-    analysis.status = wf_analysis_status.ANALYZED
+    analysis.status = analysis_status.COMPLETED
     analysis.triage_history = [
         {
             'triage_timestamp': 1438380761,
             'user_name': 'test',
             'result_status': 'dummy status',
             'version': 'dummy version',
         }
     ]
     self.assertIsNone(build_failure._GetTriageHistory(analysis))
 
   def testGetTriageHistoryWhenUserIsAdmin(self):
     analysis = WfAnalysis.Create('m', 'b', 1)
-    analysis.status = wf_analysis_status.ANALYZED
+    analysis.status = analysis_status.COMPLETED
     analysis.triage_history = [
         {
             'triage_timestamp': 1438380761,
             'user_name': 'test',
             'result_status': 'dummy status',
             'version': 'dummy version',
         }
     ]
     self.mock_current_user(user_email='test@chromium.org', is_admin=True)
     self.assertEqual(1, len(build_failure._GetTriageHistory(analysis)))
 
   def testInvalidBuildUrl(self):
     build_url = 'abc'
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*501 Not Implemented.*Url "%s" '
                    'is not pointing to a build.*' % build_url,
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/build-failure', params={'url': build_url})
 
   def testNonAdminCanViewAnalysisOfFailureOnUnsupportedMaster(self):
     master_name = 'm2'
     builder_name = 'b 1'
     build_number = 123
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number)
 
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
-    analysis.status = wf_analysis_status.ANALYZED
+    analysis.status = analysis_status.COMPLETED
     analysis.put()
 
     response = self.test_app.get('/build-failure',
                                  params={'url': build_url})
     self.assertEquals(200, response.status_int)
     self.assertEqual(0, len(self.taskqueue_stub.get_filtered_tasks()))
 
   def testNonAdminCannotRequestAnalysisOfFailureOnUnsupportedMaster(self):
     master_name = 'm2'
     builder_name = 'b 1'
@@ skipping 241 matching lines @@
     expected_result = {
         'step1 on platform':{
             'results': {
                 'reliable_failures': [
                     {
                         'try_job':{
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/119',
                             'task_id': 'task1',
                             'task_url': 'url/task1',
-                            'status': wf_analysis_status.ANALYZED,
+                            'status': analysis_status.COMPLETED,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/121'),
                             'try_job_build_number': 121,
                             'tests': ['test3'],
                             'culprit': {}
                         },
                         'heuristic_analysis': {
                             'suspected_cls': [
                                 {
@@ skipping 14 matching lines @@
                         'first_failure': 119,
                         'last_pass': 118,
                         'supported': True
                     },
                     {
                         'try_job':{
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/119',
                             'task_id': 'task1',
                             'task_url': 'url/task1',
-                            'status': wf_analysis_status.ANALYZED,
+                            'status': analysis_status.COMPLETED,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/121'),
                             'try_job_build_number': 121,
                             'culprit': {
                                 'revision': 'rev2',
                                 'commit_position': '2',
                                 'review_url': 'url_2'
                             },
                             'tests': ['test2']
@@ skipping 38 matching lines @@
                         'last_pass': 118,
                         'supported': True
                     }
                 ],
                 'unclassified_failures': [
                     {
                         'try_job':{
                             'ref_name': 'step1',
                             'try_job_key': 'm/b/120',
                             'status': result_status.NO_TRY_JOB_REASON_MAP[
-                                wf_analysis_status.PENDING],
+                                analysis_status.PENDING],
                             'task_id': 'task2',
                             'task_url': 'url/task2',
                             'tests': ['test1']
                         },
                         'heuristic_analysis': {
                             'suspected_cls': []
                         },
                         'tests': ['test1'],
                         'first_failure': 120,
                         'last_pass': 119,
@@ skipping 41 matching lines @@
     result = build_failure._GetAnalysisResultWithTryJobInfo(
         organized_results, 'm', 'b', 120)
 
     expected_result = {
         'compile':{
             'results': {
                 'reliable_failures': [
                     {
                         'try_job': {
                             'try_job_key': 'm/b/120',
-                            'status': wf_analysis_status.ANALYZED,
+                            'status': analysis_status.COMPLETED,
                             'try_job_build_number': 120,
                             'try_job_url': (
                                 'http://build.chromium.org/p/tryserver.chromium'
                                 '.linux/builders/linux_variable/builds/120'),
                             'culprit': {
                                 'revision': 'rev2',
                                 'commit_position': '2',
                                 'review_url': 'url_2'
                             }
                         },
@@ skipping 15 matching lines @@
                         'tests': [],
                         'first_failure': 120,
                         'last_pass': 119,
                         'supported': True
                     }
                 ]
             }
         }
     }
     self.assertEqual(expected_result, result)