Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2737)

Unified Diff: appengine/findit/handlers/build_failure.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/findit_api.py ('k') | appengine/findit/handlers/check_duplicate_failures.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/build_failure.py
diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py
index 150abd42f5439e6a7834bfc711e08c08d23792e5..75d62571edd555e4139e44dcea44c44dfa6dcb07 100644
--- a/appengine/findit/handlers/build_failure.py
+++ b/appengine/findit/handlers/build_failure.py
@@ -11,18 +11,18 @@ from google.appengine.api import users
from base_handler import BaseHandler
from base_handler import Permission
+from common import constants
from handlers import handlers_util
from handlers import result_status
from handlers.result_status import NO_TRY_JOB_REASON_MAP
-from model import wf_analysis_status
+from model import analysis_status
from model.wf_analysis import WfAnalysis
-from model.wf_analysis_result_status import RESULT_STATUS_TO_DESCRIPTION
+from model.result_status import RESULT_STATUS_TO_DESCRIPTION
from waterfall import build_failure_analysis_pipelines
from waterfall import buildbot
from waterfall import waterfall_config
-BUILD_FAILURE_ANALYSIS_TASKQUEUE = 'build-failure-analysis-queue'
NON_SWARMING = object()
@@ -162,7 +162,7 @@ def _GetAnalysisResultWithTryJobInfo(
'try_job':{
'ref_name': 'step1',
'try_job_key': 'm/b/119',
- 'status': wf_analysis_status.ANALYZED,
+ 'status': analysis_status.COMPLETED,
'try_job_url': 'url/121',
'try_job_build_number': 121,
},
@@ -308,7 +308,7 @@ class BuildFailure(BaseHandler):
analysis = build_failure_analysis_pipelines.ScheduleAnalysisIfNeeded(
master_name, builder_name, build_number,
build_completed=build_completed, force=force,
- queue_name=BUILD_FAILURE_ANALYSIS_TASKQUEUE)
+ queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
organized_results = _GetOrganizedAnalysisResultBySuspectedCL(
analysis.result)
« no previous file with comments | « appengine/findit/findit_api.py ('k') | appengine/findit/handlers/check_duplicate_failures.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698