Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: appengine/findit/findit_api.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/dispatch.yaml ('k') | appengine/findit/handlers/build_failure.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/findit_api.py
diff --git a/appengine/findit/findit_api.py b/appengine/findit/findit_api.py
index abd04b36fe0ee92270026f8cb439a7765f5b95e5..625f860d713c2f82fc957a80ba8ff8ede99b4de9 100644
--- a/appengine/findit/findit_api.py
+++ b/appengine/findit/findit_api.py
@@ -5,8 +5,8 @@
"""This module is to provide Findit service APIs through Cloud Endpoints:
Current APIs include:
-1. Analysis of build failures in Chromium waterfalls.
- Analyzes build failures and detects suspected CLs.
+1. Analysis of compile/test failures in Chromium waterfalls.
+ Analyzes failures and detects suspected CLs.
"""
import json
@@ -18,6 +18,7 @@ from protorpc import messages
from protorpc import remote
from common import appengine_util
+from common import constants
from model.wf_analysis import WfAnalysis
from waterfall import buildbot
from waterfall import waterfall_config
@@ -29,10 +30,6 @@ from waterfall import waterfall_config
package = 'FindIt'
-_REQUEST_PROCESS_QUEUE = 'request-process-queue'
-_REQUEST_HANDLER_URL = '/trigger-analyses'
-
-
# These subclasses of Message are basically definitions of Protocol RPC
# messages. https://cloud.google.com/appengine/docs/python/tools/protorpc/
class _BuildFailure(messages.Message):
@@ -76,11 +73,11 @@ class _BuildFailureAnalysisResultCollection(messages.Message):
def _TriggerNewAnalysesOnDemand(builds_to_check):
"""Pushes a task to run on the backend to trigger new analyses on demand."""
- target = appengine_util.GetTargetNameForModule('build-failure-analysis')
+ target = appengine_util.GetTargetNameForModule(constants.WATERFALL_BACKEND)
payload = json.dumps({'builds': builds_to_check})
taskqueue.add(
- url=_REQUEST_HANDLER_URL, payload=payload, target=target,
- queue_name=_REQUEST_PROCESS_QUEUE)
+ url=constants.WATERFALL_TRIGGER_ANALYSIS_URL, payload=payload,
+ target=target, queue_name=constants.WATERFALL_SERIAL_QUEUE)
# Create a Cloud Endpoints API.
« no previous file with comments | « appengine/findit/dispatch.yaml ('k') | appengine/findit/handlers/build_failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698