[Findit] A huge refactoring and some bug fixing.

appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import logging
 
 from common import appengine_util
-from model import wf_analysis_status
+from common import constants
+from model import analysis_status
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import BasePipeline
 from pipeline_wrapper import pipeline
 from waterfall import try_job_pipeline
 from waterfall.try_job_type import TryJobType
 
 
-# TODO(chanli): Need to figure out why try-job-queue doesn't work.
-TRY_JOB_PIPELINE_QUEUE_NAME = 'build-failure-analysis-queue'
-
-
 def _GetReliableTargetedTests(targeted_tests, classified_tests_by_step):
   """Returns a dict containing a list of reliable tests for each failed step."""
   reliable_tests = defaultdict(list)
   for step_name, tests in targeted_tests.iteritems():
     if step_name in classified_tests_by_step:  # Swarming step.
       # If the step is swarming but there is no result for it, it's highly
       # likely that there is some error with the task.
       # Thus skip this step for no insights from task to avoid false positive.
       step_name_no_platform = classified_tests_by_step[step_name][0]
       classified_tests = classified_tests_by_step[step_name][1]
@@ skipping 37 matching lines @@
     if try_job_type == TryJobType.TEST:
       targeted_tests = _GetReliableTargetedTests(
           targeted_tests, dict(classified_tests_by_step))
     if targeted_tests or try_job_type == TryJobType.COMPILE:
       new_try_job_pipeline = try_job_pipeline.TryJobPipeline(
           master_name, builder_name, build_number, good_revision,
           bad_revision, blame_list, try_job_type, compile_targets,
           targeted_tests)
 
       new_try_job_pipeline.target = appengine_util.GetTargetNameForModule(
-          'build-failure-analysis')
-      new_try_job_pipeline.start()
+          constants.WATERFALL_BACKEND)
+      new_try_job_pipeline.start(queue_name=constants.WATERFALL_TRY_JOB_QUEUE)
       logging.info('Try-job was scheduled for build %s, %s, %s: %s',
                    master_name, builder_name, build_number,
                    new_try_job_pipeline.pipeline_status_path)
     else:  # pragma: no cover
       # No need to start try job, mark it as skipped.
       try_job_result = WfTryJob.Get(
           master_name, builder_name, build_number)
       if try_job_result:
-        try_job_result.status = wf_analysis_status.SKIPPED
+        try_job_result.status = analysis_status.SKIPPED
         try_job_result.put()
       return