[Findit] A huge refactoring and some bug fixing.

appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import os
 import urllib
 import zlib
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
-from model import wf_analysis_status
+from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from model.wf_build import WfBuild
 from model.wf_step import WfStep
 from pipeline_wrapper import pipeline_handlers
 from waterfall import buildbot
 from waterfall import lock_util
 from waterfall import swarming_util
 from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
 from waterfall.test import wf_testcase
 
@@ skipping 37 matching lines @@
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number, json_api=True)
     self.mocked_urlfetch.register_handler(build_url, build_data)
 
   def testLookBackUntilGreenBuild(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 123
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Setup build data for builds:
     # 123: mock urlfetch to ensure it is fetched.
     self._MockUrlfetchWithBuildData(master_name, builder_name, 123)
     # 122: mock a build in datastore to ensure it is not fetched again.
     build = WfBuild.Create(master_name, builder_name, 122)
     build.data = self._GetBuildData(master_name, builder_name, 122)
     build.completed = True
     build.put()
     self._MockUrlfetchWithBuildData(
@@ skipping 24 matching lines @@
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])
 
   def testFirstFailureLastPassUpdating(self):
     """last pass always should just be updated once."""
     master_name = 'm'
     builder_name = 'b'
     build_number = 100
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Setup build data for builds:
     # 100: net_unitests failed, unit_tests failed.
     # 99: net_unitests passed, unit_tests failed.
     # 98: net_unitests passed, unit_tests failed.
     # 97: net_unitests failed, unit_tests failed.
     # 96: net_unitests passed, unit_tests passed.
     for i in range(5):
       self._MockUrlfetchWithBuildData(master_name, builder_name, 100 - i)
 
@@ skipping 14 matching lines @@
     }
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])
 
   def testStopLookingBackIfAllFailedStepsPassedInLastBuild(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 124
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Setup build data for builds:
     self._MockUrlfetchWithBuildData(master_name, builder_name, 124)
     self._MockUrlfetchWithBuildData(master_name, builder_name, 123,
                                     build_data=None)
     self._MockUrlfetchWithBuildData(
         master_name, builder_name, 122, build_data='Blow up if used!')
 
     pipeline = DetectFirstFailurePipeline()
     failure_info = pipeline.run(master_name, builder_name, build_number)
 
     expected_failed_steps = {
         'a': {
             'last_pass': 123,
             'current_failure': 124,
             'first_failure': 124
         }
     }
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])
 
   def testAnalyzeSuccessfulBuild(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 121
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Setup build data for builds:
     self._MockUrlfetchWithBuildData(master_name, builder_name, 121)
     self._MockUrlfetchWithBuildData(
         master_name, builder_name, 120, build_data='Blow up if used!')
 
     pipeline = DetectFirstFailurePipeline()
     failure_info = pipeline.run(master_name, builder_name, build_number)
 
     self.assertFalse(failure_info['failed'])
 
   def testStopLookingBackIfFindTheFirstBuild(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 2
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Setup build data for builds:
     self._MockUrlfetchWithBuildData(master_name, builder_name, 2)
     self._MockUrlfetchWithBuildData(master_name, builder_name, 1)
     self._MockUrlfetchWithBuildData(master_name, builder_name, 0)
 
     pipeline = DetectFirstFailurePipeline()
     failure_info = pipeline.run(master_name, builder_name, build_number)
 
     expected_failed_steps = {
@@ skipping 353 matching lines @@
         }
     }
     self.assertEqual(builds, expected_builds)
 
   def testTestLevelFailedInfo(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
 
     self._CreateAndSaveWfAnanlysis(
-        master_name, builder_name, build_number, wf_analysis_status.ANALYZING)
+        master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Mock data for retrieving data from swarming server for a build.
     self._MockUrlFetchWithSwarmingData(master_name, builder_name, 223)
 
     for n in xrange(223, 219, -1):  # pragma: no cover
       # Setup build data for builds:
       self._MockUrlfetchWithBuildData(master_name, builder_name, n)
       if n == 220:
         break
 
@@ skipping 84 matching lines @@
         221: '{"Unittest3.Subtest3": "YS9iL3UzczIuY2M6MTEwOiBGYWlsdXJlCg=="}'
     }
 
     for n in xrange(223, 220, -1):
       step = WfStep.Get(master_name, builder_name, n, 'abc_test')
       self.assertIsNotNone(step)
       self.assertTrue(step.isolated)
       self.assertEqual(expected_step_log_data[n], step.log_data)
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])