appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py - Issue 1866883002: [Findit] A huge refactoring and some bug fixing.

Unified Diff: appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Fix nit. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/build_failure_analysis_pipelines_test.py ('k') | appengine/findit/waterfall/test/identify_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py b/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

index aa5a56aba791ea6f3065c37d30ebae9fc42279b4..0f33e7fd7b8eadb72f019556f8be1e43e77fe9f8 100644

--- a/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

+++ b/appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

@@ -9,7 +9,7 @@ import urllib

import zlib

from common.http_client_appengine import HttpClientAppengine as HttpClient

-from model import wf_analysis_status

+from model import analysis_status

from model.wf_analysis import WfAnalysis

from model.wf_build import WfBuild

from model.wf_step import WfStep

@@ -67,7 +67,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 123

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Setup build data for builds:

# 123: mock urlfetch to ensure it is fetched.

@@ -112,7 +112,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 100

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Setup build data for builds:

# 100: net_unitests failed, unit_tests failed.

@@ -147,7 +147,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 124

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Setup build data for builds:

self._MockUrlfetchWithBuildData(master_name, builder_name, 124)

@@ -175,7 +175,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 121

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Setup build data for builds:

self._MockUrlfetchWithBuildData(master_name, builder_name, 121)

@@ -193,7 +193,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 2

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Setup build data for builds:

self._MockUrlfetchWithBuildData(master_name, builder_name, 2)

@@ -567,7 +567,7 @@ class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):

build_number = 223

self._CreateAndSaveWfAnanlysis(

- master_name, builder_name, build_number, wf_analysis_status.ANALYZING)

+ master_name, builder_name, build_number, analysis_status.RUNNING)

# Mock data for retrieving data from swarming server for a build.

self._MockUrlFetchWithSwarmingData(master_name, builder_name, 223)