[Findit] A huge refactoring and some bug fixing.

appengine/findit/waterfall/build_failure_analysis_pipelines.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
+from common import constants
 from model.wf_analysis import WfAnalysis
-from model import wf_analysis_status
+from model import analysis_status
 from waterfall import analyze_build_failure_pipeline
 
 @ndb.transactional
 def NeedANewAnalysis(
     master_name, builder_name, build_number, failed_steps,
     build_completed, force):
   """Checks status of analysis for the build and decides if a new one is needed.
 
   A WfAnalysis entity for the given build will be created if none exists.
   When a new analysis is needed, this function will create and save a WfAnalysis
   entity to the datastore, or it will reset the existing one but still keep the
   result of last analysis.
 
   Returns:
     True if an analysis is needed, otherwise False.
   """
   analysis = WfAnalysis.Get(master_name, builder_name, build_number)
 
   if not analysis:
     # The build failure is not analyzed yet.
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
-    analysis.status = wf_analysis_status.PENDING
+    analysis.status = analysis_status.PENDING
     analysis.request_time = datetime.utcnow()
     analysis.put()
     return True
   elif force:
     # A new analysis could be forced if last analysis was completed.
     if not analysis.completed:
       # TODO: start a new analysis if the last one has started running but it
       # has no update for a considerable amount of time, eg. 10 minutes.
       return False
 
@@ skipping 22 matching lines @@
   # TODO: support following cases
   # * Automatically retry if last analysis failed with errors.
   # * Analysis is not complete and no update in the last 5 minutes.
   return False
 
 
 def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number,
                              failed_steps=None,
                              build_completed=False,
                              force=False,
-                             queue_name='default'):
+                             queue_name=constants.DEFAULT_QUEUE):
   """Schedules an analysis if needed and returns the build analysis.
 
   When the build failure was already analyzed and a new analysis is scheduled,
   the returned WfAnalysis will still have the result of last completed analysis.
 
   Args:
     master_name (str): The master name of the failed build.
     builder_name (str): The builder name of the failed build.
     build_number (int): The build number of the failed build.
     failed_steps (list): The names of all failed steps reported for the build.
     build_completed (bool): Indicate whether the build is completed.
     force (bool): If True, a fresh new analysis will be triggered even when an
         old one was completed already; otherwise bail out.
     queue_name (str): The task queue to be used for pipeline tasks.
 
   Returns:
     A WfAnalysis instance.
   """
   if NeedANewAnalysis(
       master_name, builder_name, build_number, failed_steps,
       build_completed, force):
     pipeline_job = analyze_build_failure_pipeline.AnalyzeBuildFailurePipeline(
         master_name, builder_name, build_number, build_completed)
-    # Explicitly run analysis in the backend module "build-failure-analysis".
+    # Explicitly run analysis in the backend module "waterfall-backend".
     # Note: Just setting the target in queue.yaml does NOT work for pipeline
     # when deployed to App Engine, but it does work in dev-server locally.
     # A possible reason is that pipeline will pick a default target if none is
     # specified explicitly, and the default target is used rather than the one
     # in the queue.yaml file, but this contradicts the documentation in
     # https://cloud.google.com/appengine/docs/python/taskqueue/tasks#Task.
     pipeline_job.target = appengine_util.GetTargetNameForModule(
-        'build-failure-analysis')
+        constants.WATERFALL_BACKEND)
     pipeline_job.start(queue_name=queue_name)
 
     logging.info('An analysis was scheduled for build %s, %s, %s: %s',
                  master_name, builder_name, build_number,
                  pipeline_job.pipeline_status_path())
 
   return WfAnalysis.Get(master_name, builder_name, build_number)