[Findit] A huge refactoring and some bug fixing.

appengine/findit/findit_api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module is to provide Findit service APIs through Cloud Endpoints:
 
 Current APIs include:
-1. Analysis of build failures in Chromium waterfalls.
-   Analyzes build failures and detects suspected CLs.
+1. Analysis of compile/test failures in Chromium waterfalls.
+   Analyzes failures and detects suspected CLs.
 """
 
 import json
 import logging
 
 import endpoints
 from google.appengine.api import taskqueue
 from protorpc import messages
 from protorpc import remote
 
 from common import appengine_util
+from common import constants
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 from waterfall import waterfall_config
 
 
 # This is used by the underlying ProtoRpc when creating names for the ProtoRPC
 # messages below. This package name will show up as a prefix to the message
 # class names in the discovery doc and client libraries.
 package = 'FindIt'
 
 
-_REQUEST_PROCESS_QUEUE = 'request-process-queue'
-_REQUEST_HANDLER_URL = '/trigger-analyses'
-
-
 # These subclasses of Message are basically definitions of Protocol RPC
 # messages. https://cloud.google.com/appengine/docs/python/tools/protorpc/
 class _BuildFailure(messages.Message):
   master_url = messages.StringField(1, required=True)
   builder_name = messages.StringField(2, required=True)
   build_number = messages.IntegerField(3, variant=messages.Variant.INT32,
                                        required=True)
   # All failed steps of the build reported by the client.
   failed_steps = messages.StringField(4, repeated=True, required=False)
 
@@ skipping 23 matching lines @@
   suspected_cls = messages.MessageField(_SuspectedCL, 8, repeated=True)
 
 
 class _BuildFailureAnalysisResultCollection(messages.Message):
   """Represents a response to the client, eg. builder_alerts."""
   results = messages.MessageField(_BuildFailureAnalysisResult, 1, repeated=True)
 
 
 def _TriggerNewAnalysesOnDemand(builds_to_check):
   """Pushes a task to run on the backend to trigger new analyses on demand."""
-  target = appengine_util.GetTargetNameForModule('build-failure-analysis')
+  target = appengine_util.GetTargetNameForModule(constants.WATERFALL_BACKEND)
   payload = json.dumps({'builds': builds_to_check})
   taskqueue.add(
-      url=_REQUEST_HANDLER_URL, payload=payload, target=target,
-      queue_name=_REQUEST_PROCESS_QUEUE)
+      url=constants.WATERFALL_TRIGGER_ANALYSIS_URL, payload=payload,
+      target=target, queue_name=constants.WATERFALL_SERIAL_QUEUE)
 
 
 # Create a Cloud Endpoints API.
 # https://cloud.google.com/appengine/docs/python/endpoints/create_api
 @endpoints.api(name='findit', version='v1', description='FindIt API')
 class FindItApi(remote.Service):
   """FindIt API v1."""
 
   def _GenerateBuildFailureAnalysisResult(
       self, build, suspected_cls_in_result, step_name,
@@ skipping 78 matching lines @@
     logging.info('%d build failure(s), while %d are supported',
                  len(request.builds), len(builds_to_check))
     try:
       _TriggerNewAnalysesOnDemand(builds_to_check)
     except Exception:  # pragma: no cover.
       # If we fail to post a task to the task queue, we ignore and wait for next
       # request.
       logging.exception('Failed to trigger new analyses on demand.')
 
     return _BuildFailureAnalysisResultCollection(results=results)