Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py

Issue 1866883002: [Findit] A huge refactoring and some bug fixing. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nit. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py
diff --git a/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py b/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py
index 3c9e38238ed8e1137c3dd414cefc9beeee17f389..9311633d12c1c9683a347fab7c2fe760587b09f4 100644
--- a/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py
+++ b/appengine/findit/waterfall/run_try_job_for_reliable_failure_pipeline.py
@@ -6,7 +6,8 @@ from collections import defaultdict
import logging
from common import appengine_util
-from model import wf_analysis_status
+from common import constants
+from model import analysis_status
from model.wf_try_job import WfTryJob
from pipeline_wrapper import BasePipeline
from pipeline_wrapper import pipeline
@@ -14,10 +15,6 @@ from waterfall import try_job_pipeline
from waterfall.try_job_type import TryJobType
-# TODO(chanli): Need to figure out why try-job-queue doesn't work.
-TRY_JOB_PIPELINE_QUEUE_NAME = 'build-failure-analysis-queue'
-
-
def _GetReliableTargetedTests(targeted_tests, classified_tests_by_step):
"""Returns a dict containing a list of reliable tests for each failed step."""
reliable_tests = defaultdict(list)
@@ -75,8 +72,8 @@ class RunTryJobForReliableFailurePipeline(BasePipeline):
targeted_tests)
new_try_job_pipeline.target = appengine_util.GetTargetNameForModule(
- 'build-failure-analysis')
- new_try_job_pipeline.start()
+ constants.WATERFALL_BACKEND)
+ new_try_job_pipeline.start(queue_name=constants.WATERFALL_TRY_JOB_QUEUE)
logging.info('Try-job was scheduled for build %s, %s, %s: %s',
master_name, builder_name, build_number,
new_try_job_pipeline.pipeline_status_path)
@@ -85,6 +82,6 @@ class RunTryJobForReliableFailurePipeline(BasePipeline):
try_job_result = WfTryJob.Get(
master_name, builder_name, build_number)
if try_job_result:
- try_job_result.status = wf_analysis_status.SKIPPED
+ try_job_result.status = analysis_status.SKIPPED
try_job_result.put()
return

Powered by Google App Engine
This is Rietveld 408576698