convert //gpu to std::unique_ptr

convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org

Committed: https://crrev.com/6682b1c4aac00aee61b09ba8f6084f1790429315
Cr-Commit-Position: refs/heads/master@{#388176}

[Mostyn Bramley-Moore, 2016-04-04 19:49:26]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Mostyn Bramley-Moore, 2016-04-04 19:51:32]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 19:51:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/1

[commit-bot: I haz the power, 2016-04-04 20:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:21:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Mostyn Bramley-Moore, 2016-04-04 20:53:30]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 20:54:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/20001

[commit-bot: I haz the power, 2016-04-04 22:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 22:25:55]

Dry run: This issue passed the CQ dry run.

[Mostyn Bramley-Moore, 2016-04-05 07:13:02]

mostynb@opera.com changed reviewers:
+ sievers@chromium.org

[Mostyn Bramley-Moore, 2016-04-05 07:13:03]

@sievers: please take a look.

[no sievers, 2016-04-05 19:02:42]

just some nits, let's clean up the unused/missing includes for unique_ptr while
we're at it.

also, you're using the clang formatter? it seems to have some bug with the
pattern matching.. see unittest files

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/client_test_helper.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/client_test_helper.cc:11: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/cmd_buffer_helper_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/cmd_buffer_helper_test.cc:11: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/fenced_allocator_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/fenced_allocator_test.cc:8: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gl_in_process_context.cc (left):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gl_in_process_context.cc:14: #include <GLES2/gl2.h>
nit: can you leave GLES2/gl2.h here right above where we check what macros it
defined?

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gles2_implementation_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gles2_implementation_unittest.cc:14: #include
<stdint.h>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/program_info_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/program_info_manager_unittest.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/ring_buffer_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/ring_buffer_test.cc:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/transfer_buffer_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/transfer_buffer_unittest.cc:11: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/vertex_array_object_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/vertex_array_object_manager_unittest.cc:10: #include
<stdint.h>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/buffer_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/buffer_manager_unittest.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/cmd_parser_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/cmd_parser_test.cc:7: #include
"gpu/command_buffer/service/cmd_parser.h"
nit: This can stay where it was

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service.cc:10: #include <limits>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service.h:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service_unittest.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_executor_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_executor_unittest.cc:9: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/common_decoder_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/common_decoder_unittest.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:10: #include
<algorithm>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/memory_program_cache_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/memory_program_cache_unittest.cc:9: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.h:11: #include <map>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/query_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/query_manager_unittest.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/shader_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/shader_manager_unittest.cc:7: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/shader_translator.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/shader_translator.h:8: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/sync_point_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/sync_point_manager_unittest.cc:6: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_definition.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_definition.cc:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.h:12: #include <list>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/transfer_buffer_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/transfer_buffer_manager.h:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/valuebuffer_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/valuebuffer_manager.h:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_array_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_array_manager.h:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_array_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_array_manager_unittest.cc:5: #include
"gpu/command_buffer/service/vertex_array_manager.h"
This should stay below.
Looks like the formatting script is getting this wrong?

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_attrib_manager.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_attrib_manager.cc:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_attrib_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_attrib_manager_unittest.cc:9: #include
<memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc:9:
#include <string.h>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:9: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_readback_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_readback_unittest.cc:12: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_unittest.cc:8: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
File gpu/config/gpu_control_list_entry_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
gpu/config/gpu_control_list_entry_unittest.cc:6: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
File gpu/config/gpu_control_list_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
gpu/config/gpu_control_list_unittest.cc:5: #include
"gpu/config/gpu_control_list.h"
leave below

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_unittest.cc:5: #include
"gpu/config/gpu_driver_bug_list.h"
leave below

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector.cc:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_linux.cc:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_mac.mm (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_mac.mm:7: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_unittest.cc:5: #include
"gpu/config/gpu_info_collector.h"
leave below

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_util.cc
File gpu/config/gpu_util.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_util.cc#...
gpu/config/gpu_util.cc:6: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/egl/egl.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/egl/egl.cc:7: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/command_...
File gpu/ipc/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/command_...
gpu/ipc/client/command_buffer_proxy_impl.h:11: #include <map>
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/gpu_memo...
File gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/gpu_memo...
gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h:11: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
File gpu/tools/compositor_model_bench/compositor_model_bench.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
gpu/tools/compositor_model_bench/compositor_model_bench.cc:20: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
File gpu/tools/compositor_model_bench/shaders.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
gpu/tools/compositor_model_bench/shaders.cc:10: 
#include <memory>

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_comma...
File gpu/vulkan/vulkan_command_buffer.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_comma...
gpu/vulkan/vulkan_command_buffer.h:10: #include <memory>
unused

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_imple...
File gpu/vulkan/vulkan_implementation.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_imple...
gpu/vulkan/vulkan_implementation.h:10: #include <memory>
unused

[Mostyn Bramley-Moore, 2016-04-05 21:35:33]

I think I have fixed all the nits- (sorry there were so many of them).

I used both "git cl format" and tools/clang/pass_to_move/add_header.py patched
in from another CL, details here (I think one or both caused the unwanted
reformatting):
"https://docs.google.com/spreadsheets/d/19zyXGmZzdn9muv8ldpfOrgPaiHsxL4OHyGcnKTxcVq4/edit#gid=878688265

I also added a few more include-what-you-use fixes, so this needs another
thumbs-up.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/client_test_helper.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/client_test_helper.cc:11: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/cmd_buffer_helper_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/cmd_buffer_helper_test.cc:11: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gl_in_process_context.cc (left):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gl_in_process_context.cc:14: #include <GLES2/gl2.h>
On 2016/04/05 19:02:40, sievers wrote:
> nit: can you leave GLES2/gl2.h here right above where we check what macros it
> defined?

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gles2_implementation_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gles2_implementation_unittest.cc:14: #include
<stdint.h>
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/program_info_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/program_info_manager_unittest.cc:7: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/ring_buffer_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/ring_buffer_test.cc:10: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/transfer_buffer_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/transfer_buffer_unittest.cc:11: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/vertex_array_object_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/vertex_array_object_manager_unittest.cc:10: #include
<stdint.h>
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/buffer_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/buffer_manager_unittest.cc:7: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/cmd_parser_test.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/cmd_parser_test.cc:7: #include
"gpu/command_buffer/service/cmd_parser.h"
On 2016/04/05 19:02:40, sievers wrote:
> nit: This can stay where it was

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service.cc:10: #include <limits>
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service.h:10: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_buffer_service_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_buffer_service_unittest.cc:7: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/command_executor_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/command_executor_unittest.cc:9: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/common_decoder_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/common_decoder_unittest.cc:7: 
On 2016/04/05 19:02:40, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:10: #include
<algorithm>
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:10: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/memory_program_cache_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/memory_program_cache_unittest.cc:9: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/program_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/program_manager.h:11: #include <map>
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/query_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/query_manager_unittest.cc:7: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/shader_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/shader_manager_unittest.cc:7: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/shader_translator.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/shader_translator.h:8: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/sync_point_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/sync_point_manager_unittest.cc:6: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_definition.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_definition.cc:10: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.h:12: #include <list>
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/transfer_buffer_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/transfer_buffer_manager.h:10: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/valuebuffer_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/valuebuffer_manager.h:10: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_array_manager.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_array_manager.h:10: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_array_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_array_manager_unittest.cc:5: #include
"gpu/command_buffer/service/vertex_array_manager.h"
On 2016/04/05 19:02:41, sievers wrote:
> This should stay below.
> Looks like the formatting script is getting this wrong?

Fixed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_attrib_manager.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_attrib_manager.cc:10: #include <memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/vertex_attrib_manager_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/vertex_attrib_manager_unittest.cc:9: #include
<memory>
On 2016/04/05 19:02:41, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc:9:
#include <string.h>
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc
(right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc:9: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:10: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_readback_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_readback_unittest.cc:12: 
On 2016/04/05 19:02:41, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_unittest.cc:8: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
File gpu/config/gpu_control_list_entry_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
gpu/config/gpu_control_list_entry_unittest.cc:6: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
File gpu/config/gpu_control_list_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_control_...
gpu/config/gpu_control_list_unittest.cc:5: #include
"gpu/config/gpu_control_list.h"
On 2016/04/05 19:02:42, sievers wrote:
> leave below

Fixed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_unittest.cc:5: #include
"gpu/config/gpu_driver_bug_list.h"
On 2016/04/05 19:02:42, sievers wrote:
> leave below

Fixed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector.cc:10: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_linux.cc:10: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Fixed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_mac.mm (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_mac.mm:7: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
File gpu/config/gpu_info_collector_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_info_col...
gpu/config/gpu_info_collector_unittest.cc:5: #include
"gpu/config/gpu_info_collector.h"
On 2016/04/05 19:02:42, sievers wrote:
> leave below

Fixed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_util.cc
File gpu/config/gpu_util.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/config/gpu_util.cc#...
gpu/config/gpu_util.cc:6: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/egl/egl.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/egl/egl.cc:7: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/command_...
File gpu/ipc/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/command_...
gpu/ipc/client/command_buffer_proxy_impl.h:11: #include <map>
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/gpu_memo...
File gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/ipc/client/gpu_memo...
gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h:11: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
File gpu/tools/compositor_model_bench/compositor_model_bench.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
gpu/tools/compositor_model_bench/compositor_model_bench.cc:13: #include
<X11/keysym.h>
Moved this block back to the original location.

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
gpu/tools/compositor_model_bench/compositor_model_bench.cc:20: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
File gpu/tools/compositor_model_bench/shaders.cc (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/tools/compositor_mo...
gpu/tools/compositor_model_bench/shaders.cc:10: 
On 2016/04/05 19:02:42, sievers wrote:
> #include <memory>

Done.

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_comma...
File gpu/vulkan/vulkan_command_buffer.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_comma...
gpu/vulkan/vulkan_command_buffer.h:10: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Removed.

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_imple...
File gpu/vulkan/vulkan_implementation.h (right):

https://codereview.chromium.org/1859703002/diff/20001/gpu/vulkan/vulkan_imple...
gpu/vulkan/vulkan_implementation.h:10: #include <memory>
On 2016/04/05 19:02:42, sievers wrote:
> unused

Removed.

[Mostyn Bramley-Moore, 2016-04-05 21:36:07]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 21:36:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/60001

[commit-bot: I haz the power, 2016-04-05 21:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 21:53:03]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[Mostyn Bramley-Moore, 2016-04-05 23:08:14]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 23:08:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/80001

[commit-bot: I haz the power, 2016-04-05 23:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 23:19:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mostyn Bramley-Moore, 2016-04-05 23:26:11]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 23:26:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/100001

[commit-bot: I haz the power, 2016-04-05 23:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 23:32:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mostyn Bramley-Moore, 2016-04-06 08:13:59]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 08:14:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/120001

[commit-bot: I haz the power, 2016-04-06 08:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 08:26:52]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mostyn Bramley-Moore, 2016-04-06 09:17:40]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 09:17:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/140001

[commit-bot: I haz the power, 2016-04-06 09:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 09:42:00]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Mostyn Bramley-Moore, 2016-04-06 20:25:08]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 20:25:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/240001

[commit-bot: I haz the power, 2016-04-06 21:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:03:41]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Mostyn Bramley-Moore, 2016-04-06 21:11:36]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 21:12:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/260001

[commit-bot: I haz the power, 2016-04-06 21:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:35:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Mostyn Bramley-Moore, 2016-04-08 10:10:16]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 10:10:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/300001

[commit-bot: I haz the power, 2016-04-08 10:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 10:34:46]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Mostyn Bramley-Moore, 2016-04-09 06:07:11]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Mostyn Bramley-Moore, 2016-04-09 06:07:11]

mostynb@opera.com changed reviewers:
+ dcheng@chromium.org

[Mostyn Bramley-Moore, 2016-04-09 06:11:34]

On 2016/04/08 10:34:46, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
> (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

@dcheng: I'm a bit stumped by these errors- v4l2_format is a struct defined in
system headers, not in the content namespace.  Any ideas what might be happening
here?

[dcheng, 2016-04-09 06:16:54]

On 2016/04/09 at 06:11:34, mostynb wrote:
> On 2016/04/08 10:34:46, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
> > (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
> 
> @dcheng: I'm a bit stumped by these errors- v4l2_format is a struct defined in
system headers, not in the content namespace.  Any ideas what might be happening
here?

Not sure, but maybe try rebasing. //content is mostly using std::unique_ptr now,
and https://codereview.chromium.org/1874903002 is the last CL to finish the
conversion there.

[Mostyn Bramley-Moore, 2016-04-13 09:14:39]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 09:14:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/400001

[commit-bot: I haz the power, 2016-04-13 09:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 09:29:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Mostyn Bramley-Moore, 2016-04-13 11:49:31]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 11:49:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/420001

[Mostyn Bramley-Moore, 2016-04-13 13:42:31]

mostynb@opera.com changed reviewers:
+ brettw@chromium.org

[Mostyn Bramley-Moore, 2016-04-13 13:44:06]

@brettw: after fighting with some chromeos build flake(?), this finally looks
like it will pass the commit queue.  Can you please give it top-level OWNERS
approval before it bitrots?

[commit-bot: I haz the power, 2016-04-13 14:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 14:38:40]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-04-16 02:34:58]

sievers PTAL green bots

[danakj, 2016-04-16 02:35:35]

On 2016/04/13 13:44:06, Mostyn Bramley-Moore wrote:
> @brettw: after fighting with some chromeos build flake(?), this finally looks
> like it will pass the commit queue.  Can you please give it top-level OWNERS
> approval before it bitrots?

You can TBR brettw for the things outside gpu/

[brettw, 2016-04-18 17:04:21]

rs lgtm

[no sievers, 2016-04-18 21:05:33]

lgtm. thanks for fixing up those missing includes!

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/cli...
File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
(right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/cli...
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:7:
#include <memory>
nit: move this below under the <algorithm> and <map> include

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:13: #include
"base/memory/ptr_util.h"
nit: unused

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/jpeg_decode_accelerator_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/jpeg_decode_accelerator_unittest.cc:5: // This has to
be included first.
^^ Can you either move the include back or just remove the comment in line 5-6
also if it's an issue of the past (since the bots look green)?

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:25: #include
"content/common/gpu/media/v4l2_video_encode_accelerator.h"
remove this since you added it up there

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
File gpu/command_buffer/service/sampler_manager.h (right):

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
gpu/command_buffer/service/sampler_manager.h:8: #include <memory>
nit: unused

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
File gpu/command_buffer/service/shader_manager.h (right):

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
gpu/command_buffer/service/shader_manager.h:8: #include <memory>
nit: unused

[Mostyn Bramley-Moore, 2016-04-18 21:47:02]

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/cli...
File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
(right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/cli...
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:7:
#include <memory>
On 2016/04/18 21:05:33, sievers wrote:
> nit: move this below under the <algorithm> and <map> include

Done (but I had to disable presubmit checks when uploading).

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator.cc:13: #include
"base/memory/ptr_util.h"
On 2016/04/18 21:05:33, sievers wrote:
> nit: unused

Removed.

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/jpeg_decode_accelerator_unittest.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/jpeg_decode_accelerator_unittest.cc:5: // This has to
be included first.
On 2016/04/18 21:05:33, sievers wrote:
> ^^ Can you either move the include back or just remove the comment in line 5-6
> also if it's an issue of the past (since the bots look green)?

Moved back (but it requires me to skip presubmit checks).

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right):

https://codereview.chromium.org/1859703002/diff/420001/content/common/gpu/med...
content/common/gpu/media/v4l2_video_encode_accelerator.cc:25: #include
"content/common/gpu/media/v4l2_video_encode_accelerator.h"
On 2016/04/18 21:05:33, sievers wrote:
> remove this since you added it up there

Done.

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
File gpu/command_buffer/service/sampler_manager.h (right):

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
gpu/command_buffer/service/sampler_manager.h:8: #include <memory>
On 2016/04/18 21:05:33, sievers wrote:
> nit: unused

Removed.

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
File gpu/command_buffer/service/shader_manager.h (right):

https://codereview.chromium.org/1859703002/diff/420001/gpu/command_buffer/ser...
gpu/command_buffer/service/shader_manager.h:8: #include <memory>
On 2016/04/18 21:05:33, sievers wrote:
> nit: unused

Removed.

[Mostyn Bramley-Moore, 2016-04-18 21:47:32]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-04-18 21:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1859703002/#ps440001
(title: "rebase on master and fix nits")

[commit-bot: I haz the power, 2016-04-18 21:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/440001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/440001

[commit-bot: I haz the power, 2016-04-18 22:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 22:06:59]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mostyn Bramley-Moore, 2016-04-18 22:14:21]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

[Mostyn Bramley-Moore, 2016-04-18 22:14:39]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-04-18 22:14:41]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1859703002/#ps460001
(title: "another new fix")

[commit-bot: I haz the power, 2016-04-18 22:15:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/460001

[commit-bot: I haz the power, 2016-04-18 22:20:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 22:20:11]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Mostyn Bramley-Moore, 2016-04-18 22:36:30]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-04-18 22:37:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/460001

[commit-bot: I haz the power, 2016-04-18 22:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 22:40:37]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Mostyn Bramley-Moore, 2016-04-18 22:43:26]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win
TBR=danakj@chromium.org
==========

[Mostyn Bramley-Moore, 2016-04-18 22:44:12]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-04-18 22:44:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/460001

[commit-bot: I haz the power, 2016-04-18 22:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 22:44:37]

Transient error: Invalid delimiter in "tryserver.chromium.win":
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[Mostyn Bramley-Moore, 2016-04-18 22:46:31]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win
TBR=danakj@chromium.org
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

[Mostyn Bramley-Moore, 2016-04-18 22:49:49]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-04-18 22:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/460001

[commit-bot: I haz the power, 2016-04-19 00:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 00:34:12]

Failed to apply patch for
gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc:
While running git apply --index -3 -p1;
  error: gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc: does
not exist in index

Patch:       gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
Index: gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
diff --git a/gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
b/gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
index
29de128b1b23d85e5ac6390b34e937905f85a469..4433184df351110036278255e9f79389ad68ad59
100644
--- a/gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
+++ b/gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc
@@ -20,6 +20,7 @@
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h"
@@ -32,28 +33,28 @@ using gpu::GLInProcessContext;
 namespace gpu_blink {
 
 // static
-scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>
+std::unique_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>
 WebGraphicsContext3DInProcessCommandBufferImpl::CreateOffscreenContext(
     const gpu::gles2::ContextCreationAttribHelper& attributes) {
   bool is_offscreen = true;
-  return make_scoped_ptr(new WebGraphicsContext3DInProcessCommandBufferImpl(
-      scoped_ptr<::gpu::GLInProcessContext>(), attributes, is_offscreen,
+  return base::WrapUnique(new WebGraphicsContext3DInProcessCommandBufferImpl(
+      std::unique_ptr<::gpu::GLInProcessContext>(), attributes, is_offscreen,
       gfx::kNullAcceleratedWidget));
 }
 
-scoped_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>
+std::unique_ptr<WebGraphicsContext3DInProcessCommandBufferImpl>
 WebGraphicsContext3DInProcessCommandBufferImpl::WrapContext(
-    scoped_ptr<::gpu::GLInProcessContext> context,
+    std::unique_ptr<::gpu::GLInProcessContext> context,
     const gpu::gles2::ContextCreationAttribHelper& attributes) {
   bool is_offscreen = true;                      // Not used.
   gfx::AcceleratedWidget window = gfx::kNullAcceleratedWidget;  // Not used.
-  return make_scoped_ptr(new WebGraphicsContext3DInProcessCommandBufferImpl(
+  return base::WrapUnique(new WebGraphicsContext3DInProcessCommandBufferImpl(
       std::move(context), attributes, is_offscreen, window));
 }
 
 WebGraphicsContext3DInProcessCommandBufferImpl::
     WebGraphicsContext3DInProcessCommandBufferImpl(
-        scoped_ptr<::gpu::GLInProcessContext> context,
+        std::unique_ptr<::gpu::GLInProcessContext> context,
         const gpu::gles2::ContextCreationAttribHelper& attributes,
         bool is_offscreen,
         gfx::AcceleratedWidget window)

[commit-bot: I haz the power, 2016-04-19 00:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[Mostyn Bramley-Moore, 2016-04-19 00:54:20]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-04-19 00:55:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/460001

[commit-bot: I haz the power, 2016-04-19 01:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 01:05:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2016-04-19 07:17:38]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-04-19 07:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1859703002/#ps480001
(title: "rebase on master")

[commit-bot: I haz the power, 2016-04-19 07:17:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/480001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/480001

[commit-bot: I haz the power, 2016-04-19 08:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 08:35:10]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mostyn Bramley-Moore, 2016-04-19 08:46:42]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-04-19 08:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1859703002/#ps500001
(title: "rebase on master")

[commit-bot: I haz the power, 2016-04-19 08:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859703002/500001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859703002/500001

[commit-bot: I haz the power, 2016-04-19 10:17:41]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

[commit-bot: I haz the power, 2016-04-19 10:17:44]

Committed patchset #26 (id:500001)

[commit-bot: I haz the power, 2016-04-19 10:19:13]

Description was changed from

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org
==========

to

==========
convert //gpu to std::unique_ptr

BUG=554298
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=danakj@chromium.org

Committed: https://crrev.com/6682b1c4aac00aee61b09ba8f6084f1790429315
Cr-Commit-Position: refs/heads/master@{#388176}
==========

[commit-bot: I haz the power, 2016-04-19 10:19:16]

Patchset 26 (id:??) landed as
https://crrev.com/6682b1c4aac00aee61b09ba8f6084f1790429315
Cr-Commit-Position: refs/heads/master@{#388176}