Convert //content from scoped_ptr to std::unique_ptr

Convert //content from scoped_ptr to std::unique_ptr

BUG=554298
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Committed: https://crrev.com/6003e0b1ac1acb0a3973abbca62881d2b6acc0b1
Cr-Commit-Position: refs/heads/master@{#386303}

[dcheng, 2016-04-09 06:12:47]

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
File extensions/shell/browser/shell_url_request_context_getter.h (left):

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
extensions/shell/browser/shell_url_request_context_getter.h:44:
scoped_ptr<net::NetworkDelegate> CreateNetworkDelegate() override;
I opted to change this to use std::unique_ptr: this method is inherited from a
content/public interface, so in some sense, #including this header is a detail
of the interface.

Let me know how you feel about this.

[dcheng, 2016-04-09 06:13:51]

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
File extensions/shell/browser/shell_url_request_context_getter.h (left):

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
extensions/shell/browser/shell_url_request_context_getter.h:44:
scoped_ptr<net::NetworkDelegate> CreateNetworkDelegate() override;
On 2016/04/09 at 06:12:47, dcheng wrote:
> I opted to change this to use std::unique_ptr: this method is inherited from a
content/public interface, so in some sense, #including this header is a detail
of the interface.
> 
> Let me know how you feel about this.

"this header" == scoped_ptr.h. To clarify, this is a IWYU fix: usually I fix
those by just adding headers, but I didn't for the reason previously stated.

[Avi (use Gerrit), 2016-04-09 15:46:19]

lgtm

stampity stamp

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
File extensions/shell/browser/shell_url_request_context_getter.h (left):

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
extensions/shell/browser/shell_url_request_context_getter.h:44:
scoped_ptr<net::NetworkDelegate> CreateNetworkDelegate() override;
On 2016/04/09 06:12:47, dcheng wrote:
> I opted to change this to use std::unique_ptr: this method is inherited from a
> content/public interface, so in some sense, #including this header is a detail
> of the interface.
> 
> Let me know how you feel about this.

Fine.

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
File extensions/shell/browser/shell_url_request_context_getter.h (right):

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
extensions/shell/browser/shell_url_request_context_getter.h:53: private:
fix indent while you're in here fixing indents?

[dcheng, 2016-04-09 17:30:05]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-09 17:30:07]

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
File extensions/shell/browser/shell_url_request_context_getter.h (right):

https://codereview.chromium.org/1874903002/diff/1/extensions/shell/browser/sh...
extensions/shell/browser/shell_url_request_context_getter.h:53: private:
On 2016/04/09 at 15:46:19, Avi wrote:
> fix indent while you're in here fixing indents?

Done (though it's not me, it's clang-format!)

[dcheng, 2016-04-09 17:30:08]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1874903002/#ps40001
(title: "Fix indent")

[commit-bot: I haz the power, 2016-04-09 17:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874903002/40001

[commit-bot: I haz the power, 2016-04-09 17:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 17:41:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-04-09 17:47:44]

dcheng@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thestig@chromium.org

[dcheng, 2016-04-09 17:47:45]

TBRing thestig and rdevlin.cronin for IWYU fixes in //chrome and //extensions
respectively.

[dcheng, 2016-04-09 17:48:01]

Description was changed from

==========
Convert //content from scoped_ptr to std::unique_ptr

BUG=554298
R=avi@chromium.org
==========

to

==========
Convert //content from scoped_ptr to std::unique_ptr

BUG=554298
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org
==========

[dcheng, 2016-04-09 17:48:04]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-09 17:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874903002/40001

[commit-bot: I haz the power, 2016-04-09 18:32:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-09 18:32:40]

Internal error: failed to checkout. Please try again.

[dcheng, 2016-04-09 18:33:04]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-09 18:33:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874903002/40001

[commit-bot: I haz the power, 2016-04-09 18:42:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-09 18:44:10]

Description was changed from

==========
Convert //content from scoped_ptr to std::unique_ptr

BUG=554298
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org
==========

to

==========
Convert //content from scoped_ptr to std::unique_ptr

BUG=554298
R=avi@chromium.org
TBR=rdevlin.cronin@chromium.org,thestig@chromium.org

Committed: https://crrev.com/6003e0b1ac1acb0a3973abbca62881d2b6acc0b1
Cr-Commit-Position: refs/heads/master@{#386303}
==========

[commit-bot: I haz the power, 2016-04-09 18:44:12]

Patchset 3 (id:??) landed as
https://crrev.com/6003e0b1ac1acb0a3973abbca62881d2b6acc0b1
Cr-Commit-Position: refs/heads/master@{#386303}

[Lei Zhang, 2016-04-11 18:12:35]

chrome/ lgtm