Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: gpu/command_buffer/service/transfer_buffer_manager_unittest.cc

Issue 1859703002: convert //gpu to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/transfer_buffer_manager.h" 5 #include "gpu/command_buffer/service/transfer_buffer_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include <memory>
10
10 #include "testing/gmock/include/gmock/gmock.h" 11 #include "testing/gmock/include/gmock/gmock.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 13
13 using base::SharedMemory; 14 using base::SharedMemory;
14 15
15 namespace gpu { 16 namespace gpu {
16 17
17 const static size_t kBufferSize = 1024; 18 const static size_t kBufferSize = 1024;
18 19
19 class TransferBufferManagerTest : public testing::Test { 20 class TransferBufferManagerTest : public testing::Test {
(...skipping 13 matching lines...) Expand all
33 34
34 TEST_F(TransferBufferManagerTest, NegativeHandleMapsToNull) { 35 TEST_F(TransferBufferManagerTest, NegativeHandleMapsToNull) {
35 EXPECT_TRUE(NULL == transfer_buffer_manager_->GetTransferBuffer(-1).get()); 36 EXPECT_TRUE(NULL == transfer_buffer_manager_->GetTransferBuffer(-1).get());
36 } 37 }
37 38
38 TEST_F(TransferBufferManagerTest, OutOfRangeHandleMapsToNull) { 39 TEST_F(TransferBufferManagerTest, OutOfRangeHandleMapsToNull) {
39 EXPECT_TRUE(NULL == transfer_buffer_manager_->GetTransferBuffer(1).get()); 40 EXPECT_TRUE(NULL == transfer_buffer_manager_->GetTransferBuffer(1).get());
40 } 41 }
41 42
42 TEST_F(TransferBufferManagerTest, CanRegisterTransferBuffer) { 43 TEST_F(TransferBufferManagerTest, CanRegisterTransferBuffer) {
43 scoped_ptr<base::SharedMemory> shm(new base::SharedMemory()); 44 std::unique_ptr<base::SharedMemory> shm(new base::SharedMemory());
44 shm->CreateAndMapAnonymous(kBufferSize); 45 shm->CreateAndMapAnonymous(kBufferSize);
45 base::SharedMemory* shm_raw_pointer = shm.get(); 46 base::SharedMemory* shm_raw_pointer = shm.get();
46 scoped_ptr<SharedMemoryBufferBacking> backing( 47 std::unique_ptr<SharedMemoryBufferBacking> backing(
47 new SharedMemoryBufferBacking(std::move(shm), kBufferSize)); 48 new SharedMemoryBufferBacking(std::move(shm), kBufferSize));
48 SharedMemoryBufferBacking* backing_raw_ptr = backing.get(); 49 SharedMemoryBufferBacking* backing_raw_ptr = backing.get();
49 50
50 EXPECT_TRUE( 51 EXPECT_TRUE(
51 transfer_buffer_manager_->RegisterTransferBuffer(1, std::move(backing))); 52 transfer_buffer_manager_->RegisterTransferBuffer(1, std::move(backing)));
52 scoped_refptr<Buffer> registered = 53 scoped_refptr<Buffer> registered =
53 transfer_buffer_manager_->GetTransferBuffer(1); 54 transfer_buffer_manager_->GetTransferBuffer(1);
54 55
55 // Shared-memory ownership is transfered. It should be the same memory. 56 // Shared-memory ownership is transfered. It should be the same memory.
56 EXPECT_EQ(backing_raw_ptr, registered->backing()); 57 EXPECT_EQ(backing_raw_ptr, registered->backing());
57 EXPECT_EQ(shm_raw_pointer, backing_raw_ptr->shared_memory()); 58 EXPECT_EQ(shm_raw_pointer, backing_raw_ptr->shared_memory());
58 } 59 }
59 60
60 class FakeBufferBacking : public BufferBacking { 61 class FakeBufferBacking : public BufferBacking {
61 public: 62 public:
62 void* GetMemory() const override { 63 void* GetMemory() const override {
63 return reinterpret_cast<void*>(0xBADF00D0); 64 return reinterpret_cast<void*>(0xBADF00D0);
64 } 65 }
65 size_t GetSize() const override { return 42; } 66 size_t GetSize() const override { return 42; }
66 static scoped_ptr<BufferBacking> Make() { 67 static std::unique_ptr<BufferBacking> Make() {
67 return scoped_ptr<BufferBacking>(new FakeBufferBacking); 68 return std::unique_ptr<BufferBacking>(new FakeBufferBacking);
68 } 69 }
69 }; 70 };
70 71
71 TEST_F(TransferBufferManagerTest, CanDestroyTransferBuffer) { 72 TEST_F(TransferBufferManagerTest, CanDestroyTransferBuffer) {
72 EXPECT_TRUE(transfer_buffer_manager_->RegisterTransferBuffer( 73 EXPECT_TRUE(transfer_buffer_manager_->RegisterTransferBuffer(
73 1, scoped_ptr<BufferBacking>(new FakeBufferBacking))); 74 1, std::unique_ptr<BufferBacking>(new FakeBufferBacking)));
74 transfer_buffer_manager_->DestroyTransferBuffer(1); 75 transfer_buffer_manager_->DestroyTransferBuffer(1);
75 scoped_refptr<Buffer> registered = 76 scoped_refptr<Buffer> registered =
76 transfer_buffer_manager_->GetTransferBuffer(1); 77 transfer_buffer_manager_->GetTransferBuffer(1);
77 78
78 scoped_refptr<Buffer> null_buffer; 79 scoped_refptr<Buffer> null_buffer;
79 EXPECT_EQ(null_buffer, registered); 80 EXPECT_EQ(null_buffer, registered);
80 } 81 }
81 82
82 TEST_F(TransferBufferManagerTest, CannotRegregisterTransferBufferId) { 83 TEST_F(TransferBufferManagerTest, CannotRegregisterTransferBufferId) {
83 EXPECT_TRUE(transfer_buffer_manager_->RegisterTransferBuffer( 84 EXPECT_TRUE(transfer_buffer_manager_->RegisterTransferBuffer(
(...skipping 15 matching lines...) Expand all
99 TEST_F(TransferBufferManagerTest, DestroyUnusedTransferBufferIdDoesNotCrash) { 100 TEST_F(TransferBufferManagerTest, DestroyUnusedTransferBufferIdDoesNotCrash) {
100 transfer_buffer_manager_->DestroyTransferBuffer(1); 101 transfer_buffer_manager_->DestroyTransferBuffer(1);
101 } 102 }
102 103
103 TEST_F(TransferBufferManagerTest, CannotRegisterNullTransferBuffer) { 104 TEST_F(TransferBufferManagerTest, CannotRegisterNullTransferBuffer) {
104 EXPECT_FALSE(transfer_buffer_manager_->RegisterTransferBuffer( 105 EXPECT_FALSE(transfer_buffer_manager_->RegisterTransferBuffer(
105 0, FakeBufferBacking::Make())); 106 0, FakeBufferBacking::Make()));
106 } 107 }
107 108
108 TEST_F(TransferBufferManagerTest, CannotRegisterNegativeTransferBufferId) { 109 TEST_F(TransferBufferManagerTest, CannotRegisterNegativeTransferBufferId) {
109 scoped_ptr<base::SharedMemory> shm(new base::SharedMemory()); 110 std::unique_ptr<base::SharedMemory> shm(new base::SharedMemory());
110 shm->CreateAndMapAnonymous(kBufferSize); 111 shm->CreateAndMapAnonymous(kBufferSize);
111 EXPECT_FALSE(transfer_buffer_manager_->RegisterTransferBuffer( 112 EXPECT_FALSE(transfer_buffer_manager_->RegisterTransferBuffer(
112 -1, FakeBufferBacking::Make())); 113 -1, FakeBufferBacking::Make()));
113 } 114 }
114 115
115 } // namespace gpu 116 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/transfer_buffer_manager.cc ('k') | gpu/command_buffer/service/valuebuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698