Add support for vertex and geometry shader textures

Add support for vertex and geometry shader textures

Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782583002

Committed: https://skia.googlesource.com/skia/+/9c3f14327a38e79ab7d0cf30dfd9bf89676fde06

[Chris Dalton, 2016-03-09 19:26:43]

Description was changed from

==========
Add support for vertex and geometry shader textures

Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.

BUG=skia:
==========

to

==========
Add support for vertex and geometry shader textures

Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-03-09 19:27:46]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[Chris Dalton, 2016-03-09 19:27:47]

Greg, I'm looking for guidance on how to set up these texture limits for Vulkan.

[Chris Dalton, 2016-03-10 08:36:04]

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/gl/builders/GrG...
File src/gpu/gl/builders/GrGLProgramBuilder.h (right):

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLProgramBuilder.h:42: void nameSampler(int idx, SkString*
name) override { name->printf("Sampler%d", idx); }
Is this needed or can we name it "SamplerN" in Vulkan too? Currently it's named
to just "N" in Vulkan.

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/vk/GrVkProgramB...
File src/gpu/vk/GrVkProgramBuilder.cpp (right):

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/vk/GrVkProgramB...
src/gpu/vk/GrVkProgramBuilder.cpp:159: dsSamplerBindings[i].stageFlags =
visibility_to_vk_stage_flags(uniformInfo.fVisibility);
Will this make all the magic happen? Or is there other stuff that needs to
happen in order for samplers to appear in different shaders? Should I add an
assert here that the visibility is fragment only?

[bsalomon, 2016-03-11 14:08:36]

Everything but the Vk side lgtm (nothing looks bad in Vk, just leaving that up
to Greg).

[egdaniel, 2016-03-11 14:22:27]

Vulkan stuff seems fine to me. If you want to use the same sampler name go for
it. Besides that rebase and I we're all good.

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/gl/builders/GrG...
File src/gpu/gl/builders/GrGLProgramBuilder.h (right):

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLProgramBuilder.h:42: void nameSampler(int idx, SkString*
name) override { name->printf("Sampler%d", idx); }
On 2016/03/10 08:36:03, Chris Dalton wrote:
> Is this needed or can we name it "SamplerN" in Vulkan too? Currently it's
named
> to just "N" in Vulkan.

calling it samplerN in vulkan is fine

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/vk/GrVkProgramB...
File src/gpu/vk/GrVkProgramBuilder.cpp (right):

https://codereview.chromium.org/1782583002/diff/40001/src/gpu/vk/GrVkProgramB...
src/gpu/vk/GrVkProgramBuilder.cpp:159: dsSamplerBindings[i].stageFlags =
visibility_to_vk_stage_flags(uniformInfo.fVisibility);
On 2016/03/10 08:36:04, Chris Dalton wrote:
> Will this make all the magic happen? Or is there other stuff that needs to
> happen in order for samplers to appear in different shaders? Should I add an
> assert here that the visibility is fragment only?

That should just work.

https://codereview.chromium.org/1782583002/diff/80001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1782583002/diff/80001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:48: GR_VK_CALL(vkInterface,
GetPhysicalDeviceProperties(physDev, &properties));
Are you rebased to Tot? I believe this should be in there now.

[Chris Dalton, 2016-03-11 17:10:24]

Greg, thanks for the review.

Can I just get a quick signoff on the new rebase?

[egdaniel, 2016-03-11 17:17:55]

On 2016/03/11 17:10:24, Chris Dalton wrote:
> Greg, thanks for the review.
> 
> Can I just get a quick signoff on the new rebase?

lgtm!

[Chris Dalton, 2016-03-11 17:49:29]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2016-03-11 17:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1782583002/#ps120001
(title: "better rebase")

[commit-bot: I haz the power, 2016-03-11 17:49:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782583002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782583002/120001

[commit-bot: I haz the power, 2016-03-11 18:07:39]

Description was changed from

==========
Add support for vertex and geometry shader textures

Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add support for vertex and geometry shader textures

Adds a visibility bitfield to GrTextureAccess that controls in which
shaders the texture should be accessible. Also adds caps and
validation to ensure we don't exceed texture limits.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9c3f14327a38e79ab7d0cf30dfd9bf89676fde06
==========

[commit-bot: I haz the power, 2016-03-11 18:07:40]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/9c3f14327a38e79ab7d0cf30dfd9bf89676fde06