Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, eae+blinkwatch, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, cmumford, blink-reviews-style_chromium.org, sof, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, jsbell+idb_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. BUG=580337 Committed: https://crrev.com/eb3ca39a5d8c72f8aafb03f91e1e9d9f0c14b12c Cr-Commit-Position: refs/heads/master@{#377930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1094 lines, -494 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TimeInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 14 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 9 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 9 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 13 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/Parser.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 10 chunks +22 lines, -46 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp View 19 chunks +64 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 5 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 17 chunks +35 lines, -35 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/Values.h View 1 chunk +228 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 1 chunk +309 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 21 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 5 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 12 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
4 years, 10 months ago (2016-02-26 06:25:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738073002/1
4 years, 10 months ago (2016-02-26 06:25:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 08:20:25 UTC) #6
dgozman
lgtm
4 years, 10 months ago (2016-02-26 18:08:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738073002/1
4 years, 10 months ago (2016-02-26 18:25:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 18:37:21 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 18:38:15 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb3ca39a5d8c72f8aafb03f91e1e9d9f0c14b12c
Cr-Commit-Position: refs/heads/master@{#377930}

Powered by Google App Engine
This is Rietveld 408576698