Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h
index d3c63cc62a0aeb5a066d1e3953d89cb3213c8423..6f45483c7496baaa1fc35130c6a7eee6d91dda74 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h
@@ -10,7 +10,9 @@
namespace blink {
-class JSONObject;
+namespace protocol {
+class DictionaryValue;
+}
class RemoteObjectIdBase {
USING_FAST_MALLOC(RemoteObjectIdBase);
@@ -21,7 +23,7 @@ protected:
RemoteObjectIdBase();
~RemoteObjectIdBase() { }
- PassRefPtr<JSONObject> parseInjectedScriptId(const String&);
+ PassRefPtr<protocol::DictionaryValue> parseInjectedScriptId(const String&);
int m_injectedScriptId;
};
@@ -43,14 +45,14 @@ public:
static PassOwnPtr<RemoteCallFrameId> parse(const String&);
~RemoteCallFrameId() { }
- unsigned frameOrdinal() const { return m_frameOrdinal; }
- unsigned asyncStackOrdinal() const { return m_asyncStackOrdinal; }
+ int frameOrdinal() const { return m_frameOrdinal; }
+ int asyncStackOrdinal() const { return m_asyncStackOrdinal; }
private:
RemoteCallFrameId();
- unsigned m_frameOrdinal;
- unsigned m_asyncStackOrdinal;
+ int m_frameOrdinal;
+ int m_asyncStackOrdinal;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698