Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index be209a8aa9d87faff0db43808c450db915031848..019686297287aaf0af8165166bb4a10540244617 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -26,13 +26,16 @@ class DevToolsFunctionInfo;
class InjectedScript;
class InjectedScriptManager;
class JavaScriptCallFrame;
-class JSONObject;
class PromiseTracker;
class RemoteCallFrameId;
class ScriptRegexp;
class V8AsyncCallTracker;
class V8StackTraceImpl;
+namespace protocol {
+class DictionaryValue;
+}
+
typedef String ErrorString;
using protocol::Maybe;
@@ -58,7 +61,7 @@ public:
V8DebuggerAgentImpl(InjectedScriptManager*, V8DebuggerImpl*, int contextGroupId);
~V8DebuggerAgentImpl() override;
- void setInspectorState(PassRefPtr<JSONObject>) override;
+ void setInspectorState(PassRefPtr<protocol::DictionaryValue>) override;
void setFrontend(protocol::Frontend::Debugger* frontend) override { m_frontend = frontend; }
void clearFrontend() override;
void restore() override;
@@ -162,11 +165,11 @@ public:
const String& scriptId,
PassOwnPtr<protocol::Array<protocol::Debugger::ScriptPosition>> positions) override;
- void schedulePauseOnNextStatement(const String& breakReason, PassRefPtr<JSONObject> data) override;
+ void schedulePauseOnNextStatement(const String& breakReason, PassRefPtr<protocol::DictionaryValue> data) override;
void cancelPauseOnNextStatement() override;
bool canBreakProgram() override;
- void breakProgram(const String& breakReason, PassRefPtr<JSONObject> data) override;
- void breakProgramOnException(const String& breakReason, PassRefPtr<JSONObject> data) override;
+ void breakProgram(const String& breakReason, PassRefPtr<protocol::DictionaryValue> data) override;
+ void breakProgramOnException(const String& breakReason, PassRefPtr<protocol::DictionaryValue> data) override;
void willExecuteScript(int scriptId) override;
void didExecuteScript() override;
@@ -248,7 +251,7 @@ private:
V8DebuggerImpl* m_debugger;
int m_contextGroupId;
bool m_enabled;
- RefPtr<JSONObject> m_state;
+ RefPtr<protocol::DictionaryValue> m_state;
protocol::Frontend::Debugger* m_frontend;
v8::Isolate* m_isolate;
v8::Global<v8::Context> m_pausedContext;
@@ -259,7 +262,7 @@ private:
MuteBreakpoins m_muteBreakpoints;
String m_continueToLocationBreakpointId;
String m_breakReason;
- RefPtr<JSONObject> m_breakAuxData;
+ RefPtr<protocol::DictionaryValue> m_breakAuxData;
DebuggerStep m_scheduledDebuggerStep;
bool m_skipNextDebuggerStepOut;
bool m_javaScriptPauseScheduled;

Powered by Google App Engine
This is Rietveld 408576698