third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index ccec715960b1b486a95e99d9fbf4848c54092ef5..1c75b350157db397dd1c3c40ef18626428e379c8 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -2042,13 +2042,13 @@ void InspectorDOMAgent::getRelayoutBoundary(ErrorString* errorString, int nodeId

*relayoutBoundaryNodeId = pushNodePathToFrontend(resultNode);

}

-void InspectorDOMAgent::getHighlightObjectForTest(ErrorString* errorString, int nodeId, RefPtr<JSONObject>* result)

+void InspectorDOMAgent::getHighlightObjectForTest(ErrorString* errorString, int nodeId, RefPtr<protocol::DictionaryValue>* result)

{

Node* node = assertNode(errorString, nodeId);

if (!node)

return;

InspectorHighlight highlight(node, InspectorHighlight::defaultConfig(), true);

- *result = highlight.asJSONObject();

+ *result = highlight.asProtocolValue();

}

PassOwnPtr<protocol::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(Node* node, const String& objectGroup)