Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
index 172537edc2164f075b4208fa2a21f8d173a0c5e4..45326127b9f167a6270ab7d458162358cc7608dd 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
@@ -67,6 +67,10 @@ class WebLocalFrameImpl;
class WebString;
class WebViewImpl;
+namespace protocol {
+class Value;
+}
+
class WebDevToolsAgentImpl final
: public NoBaseWillBeGarbageCollectedFinalized<WebDevToolsAgentImpl>
, public WebDevToolsAgent
@@ -128,8 +132,8 @@ private:
void waitForCreateWindow(LocalFrame*) override;
// protocol::FrontendChannel implementation.
- void sendProtocolResponse(int sessionId, int callId, PassRefPtr<JSONObject> message) override;
- void sendProtocolNotification(PassRefPtr<JSONObject> message) override;
+ void sendProtocolResponse(int sessionId, int callId, PassRefPtr<protocol::DictionaryValue> message) override;
+ void sendProtocolNotification(PassRefPtr<protocol::DictionaryValue> message) override;
void flush() override;
// WebThread::TaskObserver implementation.
@@ -164,7 +168,7 @@ private:
InspectorAgentRegistry m_agents;
bool m_deferredAgentsInitialized;
- typedef Vector<std::pair<int, RefPtr<JSONObject>>> NotificationQueue;
+ typedef Vector<std::pair<int, RefPtr<protocol::Value>>> NotificationQueue;
NotificationQueue m_notificationQueue;
int m_sessionId;
String m_stateCookie;
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698