Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h
index b0366b0df83ec45fe68dc38aa72822c3153cd56b..b4e32af222c0e5ebaa4e73d47bb36937bc4b32b2 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h
@@ -40,10 +40,13 @@
namespace blink {
class V8EventListenerInfo;
-class JSONValue;
class V8DebuggerImpl;
class V8DebuggerAgentImpl;
+namespace protocol {
+class DictionaryValue;
+}
+
// SECURITY NOTE: Although the InjectedScriptHost is intended for use solely by the inspector,
// a reference to the InjectedScriptHost may be leaked to the page being inspected. Thus, the
// InjectedScriptHost must never implemment methods that have more power over the page than the
@@ -64,7 +67,7 @@ public:
void clearInspectedObjects();
V8RuntimeAgent::Inspectable* inspectedObject(unsigned num);
- void inspectImpl(PassRefPtr<JSONValue> objectToInspect, PassRefPtr<JSONValue> hints);
+ void inspectImpl(PassRefPtr<protocol::Value> objectToInspect, PassRefPtr<protocol::Value> hints);
void clearConsoleMessages();
void debugFunction(const String& scriptId, int lineNumber, int columnNumber);

Powered by Google App Engine
This is Rietveld 408576698