Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
index deb96ad68288beecd16ce6499f97b1e0a80027fd..9d046dfb72c784bb0e85416850c1c67abac79512 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
@@ -33,11 +33,11 @@
#include "core/CoreExport.h"
#include "core/inspector/InstrumentingAgents.h"
-#include "platform/JSONValues.h"
#include "platform/heap/Handle.h"
#include "platform/inspector_protocol/Dispatcher.h"
#include "platform/inspector_protocol/Frontend.h"
#include "platform/inspector_protocol/TypeBuilder.h"
+#include "platform/inspector_protocol/Values.h"
#include "wtf/Forward.h"
#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
@@ -66,14 +66,14 @@ public:
virtual void discardAgent() { }
virtual void didCommitLoadForLocalFrame(LocalFrame*) { }
virtual void flushPendingProtocolNotifications() { }
- virtual void setState(PassRefPtr<JSONObject>);
+ virtual void setState(PassRefPtr<protocol::DictionaryValue>);
String name() const { return m_name; }
void appended(InstrumentingAgents*);
protected:
RawPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
- RefPtr<JSONObject> m_state;
+ RefPtr<protocol::DictionaryValue> m_state;
private:
String m_name;
@@ -99,7 +99,7 @@ public:
private:
RawPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
- RefPtr<JSONObject> m_state;
+ RefPtr<protocol::DictionaryValue> m_state;
WillBeHeapVector<OwnPtrWillBeMember<InspectorAgent>> m_agents;
};

Powered by Google App Engine
This is Rietveld 408576698