Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
index 9894fc3d854c84bf4265847190ce8d629bfe09d3..ece0f9d7cb42e6b59d5d7e22cfd35b3bbe07eb0b 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
@@ -41,11 +41,14 @@
namespace blink {
class InjectedScriptManager;
-class JSONValue;
class RemoteObjectId;
class V8FunctionCall;
class V8DebuggerClient;
+namespace protocol {
+class DictionaryValue;
+}
+
typedef String ErrorString;
using protocol::Maybe;
@@ -122,9 +125,9 @@ private:
bool canAccessInspectedWindow() const;
v8::Local<v8::Value> v8Value() const;
v8::Local<v8::Value> callFunctionWithEvalEnabled(V8FunctionCall&, bool& hadException) const;
- void makeCall(V8FunctionCall&, RefPtr<JSONValue>* result);
+ void makeCall(V8FunctionCall&, RefPtr<protocol::Value>* result);
void makeEvalCall(ErrorString*, V8FunctionCall&, OwnPtr<protocol::Runtime::RemoteObject>* result, Maybe<bool>* wasThrown, Maybe<protocol::Runtime::ExceptionDetails>* = 0);
- void makeCallWithExceptionDetails(V8FunctionCall&, RefPtr<JSONValue>* result, Maybe<protocol::Runtime::ExceptionDetails>*);
+ void makeCallWithExceptionDetails(V8FunctionCall&, RefPtr<protocol::Value>* result, Maybe<protocol::Runtime::ExceptionDetails>*);
InjectedScriptManager* m_manager;
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698