third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp - Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

index 3d9078c5dbdc2b4a7ff1a37d93aea8540e15108e..e6d96f18ebf4f3d1570b12fe6174b1a2b2fca3e2 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

@@ -4,8 +4,7 @@

#include "platform/v8_inspector/V8InjectedScriptHost.h"

-#include "platform/JSONValues.h"

-#include "platform/JSONValuesForV8.h"

+#include "platform/inspector_protocol/Values.h"

#include "platform/v8_inspector/InjectedScript.h"

#include "platform/v8_inspector/InjectedScriptHost.h"

#include "platform/v8_inspector/InspectorWrapper.h"

@@ -14,6 +13,7 @@

#include "platform/v8_inspector/V8StringUtil.h"

#include "platform/v8_inspector/public/V8DebuggerClient.h"

#include "platform/v8_inspector/public/V8EventListenerInfo.h"

+#include "platform/v8_inspector/public/V8ToProtocolValue.h"

#include "wtf/HashSet.h"

#include "wtf/NonCopyingSort.h"

#include "wtf/RefPtr.h"

@@ -272,7 +272,7 @@ void V8InjectedScriptHost::inspectCallback(const v8::FunctionCallbackInfo<v8::Va

v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();

InjectedScriptHost* host = V8InjectedScriptHost::unwrap(context, info.Holder());

- host->inspectImpl(toJSONValue(context, info[0]), toJSONValue(context, info[1]));

+ host->inspectImpl(toProtocolValue(context, info[0]), toProtocolValue(context, info[1]));

}

void V8InjectedScriptHost::evalCallback(const v8::FunctionCallbackInfo<v8::Value>& info)