third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp - Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp ('k') | third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

index 742d933d2cc7a3a5da23a805b79d18d22b8fd6f8..8562eb90b63c5bc8b85e017aa71cb4ce894f0ffe 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

@@ -14,7 +14,7 @@

#include "modules/accessibility/AXObject.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

#include "modules/accessibility/InspectorTypeBuilderHelper.h"

-#include "platform/JSONValues.h"

+#include "platform/inspector_protocol/Values.h"

namespace blink {

@@ -256,7 +256,7 @@ PassOwnPtr<AXProperty> createRelatedNodeListProperty(const String& key, AXObject

{

OwnPtr<AXValue> nodeListValue = createRelatedNodeListValue(nodes);

const AtomicString& attrValue = axObject->getAttribute(attr);

- nodeListValue->setValue(JSONString::create(attrValue).get());

+ nodeListValue->setValue(protocol::StringValue::create(attrValue).get());

return createProperty(key, nodeListValue.release());

}