third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h - Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

index de6b6cebccccfccb33590a986b04b7df6aa422aa..b92f00362f7a75ac68baaad222a24fa1a0376a06 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

@@ -25,7 +25,7 @@ public:

explicit V8ProfilerAgentImpl(V8Debugger*);

~V8ProfilerAgentImpl() override;

- void setInspectorState(PassRefPtr<JSONObject> state) override { m_state = state; }

+ void setInspectorState(PassRefPtr<protocol::DictionaryValue> state) override { m_state = state; }

void setFrontend(protocol::Frontend::Profiler* frontend) override { m_frontend = frontend; }

void clearFrontend() override;

void restore() override;

@@ -52,7 +52,7 @@ private:

V8DebuggerImpl* m_debugger;

v8::Isolate* m_isolate;

- RefPtr<JSONObject> m_state;

+ RefPtr<protocol::DictionaryValue> m_state;

protocol::Frontend::Profiler* m_frontend;

bool m_enabled;

bool m_recordingCPUProfile;