Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1738073002: DevTools: introduce protocol::Value, baseline for hierarchical data in remote debugging protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
index 5ce5f84745187f63f6065c4c4a3f06edcb223aa5..63ce0fa229400c4d2e3a328f353e64933605f2dd 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -46,11 +46,14 @@ class Element;
class Event;
class EventTarget;
class InspectorDOMAgent;
-class JSONObject;
class Node;
class V8DebuggerAgent;
class V8RuntimeAgent;
+namespace protocol {
+class DictionaryValue;
+}
+
typedef String ErrorString;
class CORE_EXPORT InspectorDOMDebuggerAgent final
@@ -107,13 +110,13 @@ public:
private:
InspectorDOMDebuggerAgent(v8::Isolate*, InspectorDOMAgent*, V8RuntimeAgent*, V8DebuggerAgent*);
- void pauseOnNativeEventIfNeeded(PassRefPtr<JSONObject> eventData, bool synchronous);
- PassRefPtr<JSONObject> preparePauseOnNativeEventData(const String& eventName, const String* targetName);
+ void pauseOnNativeEventIfNeeded(PassRefPtr<protocol::DictionaryValue> eventData, bool synchronous);
+ PassRefPtr<protocol::DictionaryValue> preparePauseOnNativeEventData(const String& eventName, const String* targetName);
- PassRefPtr<JSONObject> eventListenerBreakpoints();
- PassRefPtr<JSONObject> xhrBreakpoints();
+ PassRefPtr<protocol::DictionaryValue> eventListenerBreakpoints();
+ PassRefPtr<protocol::DictionaryValue> xhrBreakpoints();
- void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, JSONObject* description);
+ void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, protocol::DictionaryValue* description);
void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set);
bool hasBreakpoint(Node*, int type);
void setBreakpoint(ErrorString*, const String& eventName, const String& targetName);

Powered by Google App Engine
This is Rietveld 408576698