Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1626553002: Revert of added support for PLS path rendering (Closed)

Created:
4 years, 11 months ago by ethannicholas
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of added support for PLS path rendering (patchset #16 id:360001 of https://codereview.chromium.org/1541903002/ ) Reason for revert: ASAN failure at src/gpu/GrXferProcessor.cpp:224 Original issue's description: > added support for PLS path rendering > > BUG=skia:3555 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1541903002 > > Committed: https://skia.googlesource.com/skia/+/7df3f5e127f8016d17b637cc48a6a4718f1a6822 TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3555 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626553002 Committed: https://skia.googlesource.com/skia/+/5366a09ed07e886dd5fd1b94828241c53df3726d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1651 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrCaps.h View 1 2 chunks +0 lines, -20 lines 0 comments Download
M include/gpu/GrConfig.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M include/gpu/GrShaderVar.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 14 chunks +13 lines, -53 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 1 chunk +5 lines, -9 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 3 chunks +0 lines, -28 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
D src/gpu/GrPLSGeometryProcessor.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 3 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 4 chunks +6 lines, -22 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
D src/gpu/batches/GrPLSPathRenderer.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/gpu/batches/GrPLSPathRenderer.cpp View 1 chunk +0 lines, -1011 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 3 chunks +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 3 chunks +8 lines, -11 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 3 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 chunks +1 line, -11 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 2 chunks +23 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 4 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 9 chunks +2 lines, -202 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLUniformHandler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 3 chunks +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 4 chunks +0 lines, -21 lines 0 comments Download
D src/gpu/glsl/GrGLSLPLSPathRendering.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 1 4 chunks +5 lines, -12 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 1 5 chunks +8 lines, -14 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ethannicholas
Created Revert of added support for PLS path rendering
4 years, 11 months ago (2016-01-22 17:39:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626553002/1
4 years, 11 months ago (2016-01-22 17:40:01 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/utils/debugger/SkOverdrawMode.cpp: While running git apply --index -3 -p1; error: src/utils/debugger/SkOverdrawMode.cpp: ...
4 years, 11 months ago (2016-01-22 17:40:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626553002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626553002/300001
4 years, 11 months ago (2016-01-22 17:45:30 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:45:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:300001) as
https://skia.googlesource.com/skia/+/5366a09ed07e886dd5fd1b94828241c53df3726d

Powered by Google App Engine
This is Rietveld 408576698