Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, penghuang+watch-mandoline_chromium.org, rjkroege, telemetry-reviews_chromium.org, tfarina, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry + tools/perf] Modify the pylint disable message to use symbolic name BUG=558742 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect Committed: https://crrev.com/f71b68c3af40d396f5d18e0352a51f907755f813 Cr-Commit-Position: refs/heads/master@{#360742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -306 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/fetch_benchmark_deps_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/cpu.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/cpu_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/media.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/memory.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/speedindex.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/speedindex_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/metrics/system_memory.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/flash_energy_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/google_pages.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/infinite_scroll_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_es_fr_pt-BR.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/intl_hi_ru.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_ja_zh.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/intl_ko_th_vi.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_desktop_sites.py View 3 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_pages.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_repaint.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_search_mobile.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/long_running_idle_google_cases.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/media_cns_cases.py View 2 chunks +28 lines, -28 lines 0 comments Download
M tools/perf/page_sets/mobile_memory.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/mse_cases.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/page_cycler/alexa_us.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/bloat.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/dhtml.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/dom.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/intl1.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/intl2.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/page_cycler/morejs.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/morejsnp.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/page_cycler/moz.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_cycler/moz2.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/page_reload_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/service_worker_micro_benchmark.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_25_repaint.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_25_smooth.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/top_desktop_sites_2012Q3.py View 12 chunks +16 lines, -16 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases.py View 4 chunks +46 lines, -46 lines 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.py View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 10 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/page_sets/tough_texture_upload_cases.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/typical_25.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/profile_creators/profile_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/local_server.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/os_version.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/decorators.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/decorators_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/android_browser_backend_settings.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/android_command_line_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/form_based_credentials_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/google_credentials_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser_credentials.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/extension_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/tab_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/cros_forwarder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/image_processing/screen_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/image_processing/video_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/desktop_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/linux_based_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/linux_based_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/mac_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/mac_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/network_controller_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/posix_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/posix_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/android_temperature_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/android_screen_recorder_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/android_systrace_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/monsoon.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/oomkiller_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/vtune_profiler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/platform/win_platform_backend.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/internal/results/page_test_results.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/testing/discoverable_classes/another_discover_dummyclass.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/util/webpagereplay.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/progress_reporter.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/run_chromeos_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/run_tests.py View 4 chunks +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/testing/simple_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/simple_mock_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/system_stub.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/counter.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/event_container.py View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/timeline/thread.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/color_histogram.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/util/process_statistic_timeline_data.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/smooth_gesture_util.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
eakuefner
lgtm if you have verified that there are no lint errors.
5 years, 1 month ago (2015-11-20 00:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458083003/1
5 years, 1 month ago (2015-11-20 00:40:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 02:37:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458083003/1
5 years, 1 month ago (2015-11-20 03:06:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 04:14:10 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 04:15:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f71b68c3af40d396f5d18e0352a51f907755f813
Cr-Commit-Position: refs/heads/master@{#360742}

Powered by Google App Engine
This is Rietveld 408576698