tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py b/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

index ad79f4b49d12bc98bb10062136c339a2d6902e87..4179f174f8f4b30e5107d74301f0c408e23bee6c 100644

--- a/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

+++ b/tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py

@@ -271,7 +271,7 @@ class ActualPageRunEndToEndTests(unittest.TestCase):

# This is so we can check later that the test actually made it into this

# function. Previously it was timing out before even getting here, which

# should fail, but since it skipped all the asserts, it slipped by.

- self.hasRun = True # pylint: disable=W0201

+ self.hasRun = True # pylint: disable=attribute-defined-outside-init

test = TestUserAgent()

options = options_for_unittests.GetCopy()

« no previous file with comments | « tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »