tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/forwarders/cros_forwarder_unittest.py ('k') | tools/telemetry/telemetry/internal/image_processing/screen_finder_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py

diff --git a/tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py b/tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py

index 6e8f194d199fa1b1ac0bd65d34ce55216342713d..1e08ff7a29bb8fd43bb991d525b8fa40a2f5018b 100644

--- a/tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py

+++ b/tools/telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py

@@ -47,7 +47,8 @@ class DoNothingForwarder(forwarders.Forwarder):

def _CheckPortPairs(self):

# namedtuple._asdict() is a public method. The method starts with an

- # underscore to avoid conflicts with attribute names. pylint: disable=W0212

+ # underscore to avoid conflicts with attribute names.

+ # pylint: disable=protected-access

for protocol, port_pair in self._port_pairs._asdict().items():

if not port_pair:

continue