Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/benchmark_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/benchmark_smoke_unittest.py
diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py
index c0a7b012cea3c32ed24df954845034faccde41f2..333ee0a3b3eafb0105b899e12d7a9fd9ebb2a7a4 100644
--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py
+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py
@@ -46,7 +46,7 @@ def SmokeTestGenerator(benchmark):
benchmark.options['pageset_repeat'] = 1
benchmark.options['page_repeat'] = 1
- class SinglePageBenchmark(benchmark): # pylint: disable=W0232
+ class SinglePageBenchmark(benchmark): # pylint: disable=no-init
def CreateStorySet(self, options):
# pylint: disable=E1002
story_set = super(SinglePageBenchmark, self).CreateStorySet(options)
@@ -128,7 +128,7 @@ def load_tests(loader, standard_tests, pattern):
method = SmokeTestGenerator(benchmark)
# Make sure any decorators are propagated from the original declaration.
- # (access to protected members) pylint: disable=W0212
+ # (access to protected members) pylint: disable=protected-access
# TODO(dpranke): Since we only pick the first test from every class
# (above), if that test is disabled, we'll end up not running *any*
# test from the class. We should probably discover all of the tests
« no previous file with comments | « no previous file | tools/perf/benchmarks/benchmark_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698