Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py
diff --git a/tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py b/tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py
index 924bc0f21445f1ed6ed7b8a6db252837f1a57ea6..faf2060c9e0152f1d010376e88a921d6438e3366 100644
--- a/tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py
+++ b/tools/telemetry/telemetry/internal/backends/remote/trybot_browser_finder_unittest.py
@@ -96,7 +96,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
trybot_browser_finder.urllib2 = simple_mock.MockObject()
self.assertEquals(
[],
- # pylint: disable=W0212
+ # pylint: disable=protected-access
sorted(trybot_browser_finder.FindAllBrowserTypes(finder_options)))
def test_constructor(self):
@@ -109,7 +109,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
browser = trybot_browser_finder.PossibleTrybotBrowser(
'trybot-android-nexus4', finder_options)
self.assertEquals('android', browser.target_os)
- # pylint: disable=W0212
+ # pylint: disable=protected-access
self.assertTrue('android' in browser._builder_names)
self.assertEquals(['android_nexus4_perf_bisect'],
browser._builder_names.get('android'))
@@ -142,7 +142,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
browser = trybot_browser_finder.PossibleTrybotBrowser(
'trybot-all', finder_options)
self.assertEquals('all', browser.target_os)
- # pylint: disable=W0212
+ # pylint: disable=protected-access
self.assertEquals(
['android', 'linux', 'mac', 'win', 'win-x64'],
sorted(browser._builder_names))
@@ -173,7 +173,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
browser = trybot_browser_finder.PossibleTrybotBrowser(
'trybot-all-win', finder_options)
self.assertEquals('all', browser.target_os)
- # pylint: disable=W0212
+ # pylint: disable=protected-access
self.assertEquals(
['win', 'win-x64'],
sorted(browser._builder_names))
@@ -211,7 +211,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
browser = trybot_browser_finder.PossibleTrybotBrowser(
'trybot-all-mac', finder_options)
self.assertEquals('all', browser.target_os)
- # pylint: disable=W0212
+ # pylint: disable=protected-access
self.assertEquals(
['mac'],
sorted(browser._builder_names))
@@ -231,7 +231,7 @@ class TrybotBrowserFinderTest(unittest.TestCase):
browser = trybot_browser_finder.PossibleTrybotBrowser(
'trybot-all-linux', finder_options)
self.assertEquals('all', browser.target_os)
- # pylint: disable=W0212
+ # pylint: disable=protected-access
self.assertEquals(
['linux'],
sorted(browser._builder_names))

Powered by Google App Engine
This is Rietveld 408576698