tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/platform/power_monitor/sysfs_power_monitor_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py

diff --git a/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py b/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py

index 9ad2e01170cf4604f51fd3cc42be9316abc31f01..3fddf923c7166d96eb6a5a8d8f91f5eb8d8a9992 100644

--- a/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py

+++ b/tools/telemetry/telemetry/internal/platform/profiler/android_profiling_helper.py

@@ -17,7 +17,7 @@ from telemetry.core import util

from telemetry import decorators

from telemetry.internal.platform.profiler import android_prebuilt_profiler_helper

-from devil.android import md5sum # pylint: disable=F0401

+from devil.android import md5sum # pylint: disable=import-error

try:

@@ -79,7 +79,7 @@ def _FindMatchingUnstrippedLibraryOnHost(device, lib):

# libraries are compatible.

# TODO(skyostil): Check .note.gnu.build-id instead once we're using

# --build-id=sha1.

- # pylint: disable=W0631

+ # pylint: disable=undefined-loop-variable

if (_ElfSectionMd5Sum(unstripped_host_lib, _TEXT_SECTION) !=

_ElfSectionMd5Sum(stripped_host_lib, _TEXT_SECTION)):

return None