tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/util/webpagereplay.py ('k') | tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py

diff --git a/tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py b/tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py

index bfc40b090f4867cf8eddd9a1f4975e682de4fdce..518e0d23baff42b69be6b35baf5b56951ba6e8ec 100644

--- a/tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py

+++ b/tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py

@@ -8,7 +8,7 @@ import unittest

from telemetry.internal.util import webpagereplay

-# pylint: disable=W0212

+# pylint: disable=protected-access

class CreateCommandTest(unittest.TestCase):

def testHasDnsGivesDnsPort(self):

expected_cmd_line = [

@@ -29,7 +29,7 @@ class CreateCommandTest(unittest.TestCase):

self.assertEqual(expected_cmd_line, cmd_line)

-# pylint: disable=W0212

+# pylint: disable=protected-access

class ParseLogFilePortsTest(unittest.TestCase):

def testEmptyLinesGivesEmptyDict(self):

log_lines = iter([])