tools/telemetry/telemetry/util/process_statistic_timeline_data.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/util/process_statistic_timeline_data.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/util/color_histogram.py ('k') | tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/util/process_statistic_timeline_data.py

diff --git a/tools/telemetry/telemetry/util/process_statistic_timeline_data.py b/tools/telemetry/telemetry/util/process_statistic_timeline_data.py

index b44f03ddb5b43183088accfbcaca0e513b3440ca..589e8d35ba2bf5c5cfdb7484541556f2a373089f 100644

--- a/tools/telemetry/telemetry/util/process_statistic_timeline_data.py

+++ b/tools/telemetry/telemetry/util/process_statistic_timeline_data.py

@@ -21,7 +21,7 @@ class ProcessStatisticTimelineData(object):

The motivation is that some processes may have died between two consecutive

measurements. The desired behavior is to only make calculations based on

the processes that are alive at the end of the second measurement."""

- # pylint: disable=W0212

+ # pylint: disable=protected-access

ret = self.__class__(0, 0)

my_dict = self._value_by_pid

@@ -33,7 +33,7 @@ class ProcessStatisticTimelineData(object):

def __add__(self, other):

"""The result contains pids from both |self| and |other|, if duplicate

pids are found between objects, an error will occur. """

- # pylint: disable=W0212

+ # pylint: disable=protected-access

intersecting_pids = (set(self._value_by_pid.keys()) &

set(other._value_by_pid.keys()))

assert len(intersecting_pids) == 0