tools/telemetry/telemetry/timeline/event_container.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/timeline/event_container.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/timeline/event_container.py

diff --git a/tools/telemetry/telemetry/timeline/event_container.py b/tools/telemetry/telemetry/timeline/event_container.py

index 6c1b3c2d105803d280c3023c11b0b5268160e4af..4d41e68da75acf4c0366f4eb76b973b01ea7936f 100644

--- a/tools/telemetry/telemetry/timeline/event_container.py

+++ b/tools/telemetry/telemetry/timeline/event_container.py

@@ -26,9 +26,7 @@ class TimelineEventContainer(object):

def IterChildContainers(self):

raise NotImplementedError()

- def IterEventsInThisContainer(self,

- event_type_predicate, # pylint: disable=W0613

- event_predicate): # pylint: disable=W0613

+ def IterEventsInThisContainer(self, event_type_predicate, event_predicate):

"""Iterates all the TimelineEvents in this container.

Only events with a type matching event_type_predicate AND matching event

@@ -45,8 +43,9 @@ class TimelineEventContainer(object):

of the method.

"""

+ del event_type_predicate, event_predicate # unused

return

- yield # pylint: disable=W0101

+ yield # pylint: disable=unreachable

def IterAllEvents(self,

« no previous file with comments | « tools/telemetry/telemetry/timeline/counter.py ('k') | tools/telemetry/telemetry/timeline/model.py » ('j') | no next file with comments »