Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 5d267867bd2035eac30c61204b2a53568fcb5700..bb2e5cedc9534a972d810b4f2667e3d7a4fc2ffe 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -90,7 +90,7 @@ class PageTest(object):
"""
return self._needs_browser_restart_after_each_page
- def StopBrowserAfterPage(self, browser, page): # pylint: disable=W0613
+ def StopBrowserAfterPage(self, browser, page):
"""Should the browser be stopped after the page is run?
This is called after a page is run to decide whether the browser needs to
@@ -100,6 +100,7 @@ class PageTest(object):
A test that overrides this can look at both the page and the browser to
decide whether it needs to stop the browser.
"""
+ del browser, page # unused
return False
def CustomizeBrowserOptions(self, options):
@@ -129,7 +130,7 @@ class PageTest(object):
def DidRunPage(self, platform):
"""Called after the test run method was run, even if it failed."""
- def TabForPage(self, page, browser): # pylint: disable=W0613
+ def TabForPage(self, page, browser): # pylint: disable=unused-argument
"""Override to select a different tab for the page. For instance, to
create a new tab for every page, return browser.tabs.New()."""
try:

Powered by Google App Engine
This is Rietveld 408576698