tools/telemetry/telemetry/internal/util/webpagereplay.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/util/webpagereplay.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/testing/discoverable_classes/another_discover_dummyclass.py ('k') | tools/telemetry/telemetry/internal/util/webpagereplay_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/util/webpagereplay.py

diff --git a/tools/telemetry/telemetry/internal/util/webpagereplay.py b/tools/telemetry/telemetry/internal/util/webpagereplay.py

index 87f83a0b75cfcb420c8e768776e3183e4fd2bf99..d08a00f68de03bf78c0709a2af921765f474df80 100644

--- a/tools/telemetry/telemetry/internal/util/webpagereplay.py

+++ b/tools/telemetry/telemetry/internal/util/webpagereplay.py

@@ -243,7 +243,7 @@ class ReplayServer(object):

try:

# Use a SIGINT so that it can do graceful cleanup.

self.replay_process.send_signal(signal.SIGINT)

- except: # pylint: disable=W0702

+ except: # pylint: disable=bare-except

# On Windows, we are left with no other option than terminate().

is_primary_nameserver_changed_by_replay = (

self._use_dns_server and self._replay_host == '127.0.0.1')

@@ -261,7 +261,7 @@ class ReplayServer(object):

'the primary nameserver. That might not be restored!')

try:

self.replay_process.terminate()

- except: # pylint: disable=W0702

+ except: # pylint: disable=bare-except

pass

self.replay_process.wait()