tools/telemetry/telemetry/internal/image_processing/video_unittest.py - Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/image_processing/video_unittest.py

Issue 1458083003: [Telemetry + tools/perf] Modify the pylint disable message to use symbolic name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/image_processing/screen_finder_unittest.py ('k') | tools/telemetry/telemetry/internal/platform/desktop_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/image_processing/video_unittest.py

diff --git a/tools/telemetry/telemetry/internal/image_processing/video_unittest.py b/tools/telemetry/telemetry/internal/image_processing/video_unittest.py

index 7cbf4e6e3e74c2f8864bcb42849ad4f4b7986e58..0f83ff5a8a3f146cf44833ce78b02b711acf191a 100644

--- a/tools/telemetry/telemetry/internal/image_processing/video_unittest.py

+++ b/tools/telemetry/telemetry/internal/image_processing/video_unittest.py

@@ -24,7 +24,7 @@ class VideoTest(unittest.TestCase):

finally:

if not host_platform.CanLaunchApplication('avconv'):

logging.warning('Test not supported on this platform')

- return # pylint: disable=W0150

+ return # pylint: disable=lost-exception

vid = os.path.join(util.GetUnittestDataDir(), 'vid.mp4')

expected_timestamps = [

@@ -41,7 +41,7 @@ class VideoTest(unittest.TestCase):

video_obj = video.Video(vid)

# Calling _FramesFromMp4 should return all frames.

- # pylint: disable=W0212

+ # pylint: disable=protected-access

for i, timestamp_bitmap in enumerate(video_obj._FramesFromMp4(vid)):

timestamp, bmp = timestamp_bitmap

self.assertEquals(timestamp, expected_timestamps[i])