Move shader compiling to ProgramBuilder and various ShaderBuilder cleanups.

Move shader compiling to ProgramBuilder and various ShaderBuilder cleanups.

An additional positive of this CL is that GrGLShaderBuilder is now GL independent besides GrGLProgramBuilder

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/574a4c153d8a3f42b2806848f5c23cbf55e18bbb

[egdaniel, 2015-10-30 14:34:23]

Description was changed from

==========
Move shader compiling to ProgramBuilder and various ShaderBuilder cleanups.

BUG=skia:
==========

to

==========
Move shader compiling to ProgramBuilder and various ShaderBuilder cleanups.

An additional positive of this CL is that GrGLShaderBuilder is now GL
independent besides GrGLProgramBuilder

BUG=skia:
==========

[egdaniel, 2015-10-30 15:56:46]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[egdaniel, 2015-10-30 15:56:47]

ptal

[robertphillips, 2015-10-30 16:39:46]

lgtm

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
File src/gpu/gl/builders/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLShaderBuilder.cpp:179:
this->compileAndAppendLayoutQualifiers();
\n somewhere ?

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLShaderBuilder.cpp:181: this->appendDecls(fInputs,
&this->inputs());
can this be on one line ?

[bsalomon, 2015-10-30 17:10:53]

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/glsl/GrGLSLCaps.h
File src/gpu/glsl/GrGLSLCaps.h (right):

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/glsl/GrGLSLCaps...
src/gpu/glsl/GrGLSLCaps.h:77: bool textureSwizzleSupport() const { return
fTextureSwizzleSupport; }
These two seem like features of the API and not of the shading language...
They're used only on the API side.

The way we handle this is tied to our not so great mapping between GL formats
and GrPixelConfigs. I wonder if there is any way to handle this that would add
some flexibility. E.g., could the GLSL caps get populated with a table that
holds four swizzle values for each GrPixelConfig? The GL impl could base the
table on whether R8 is supported and whether texture swizzling is supported.

We currently use texture swizzling to implement R/B swaps for read-/write-pixels
codepaths. I'd be happy to drop that if it could improve this somehow. I doubt
having the extra shader is worth much complexity.

[egdaniel, 2015-10-30 18:24:20]

Okay, I removed the swizzling stuff from this cl and will create a new
specifically for what we've talked about.

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
File src/gpu/gl/builders/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLShaderBuilder.cpp:179:
this->compileAndAppendLayoutQualifiers();
On 2015/10/30 16:39:46, robertphillips wrote:
> \n somewhere ?

Done.

https://codereview.chromium.org/1431433003/diff/40001/src/gpu/gl/builders/GrG...
src/gpu/gl/builders/GrGLShaderBuilder.cpp:181: this->appendDecls(fInputs,
&this->inputs());
On 2015/10/30 16:39:46, robertphillips wrote:
> can this be on one line ?

sadly no, 101 chars

[bsalomon, 2015-10-30 18:56:16]

lgtm

[egdaniel, 2015-11-02 14:10:34]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2015-11-02 14:10:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1431433003/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2015-11-02 14:10:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431433003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431433003/80001

[commit-bot: I haz the power, 2015-11-02 14:22:47]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/574a4c153d8a3f42b2806848f5c23cbf55e18bbb