Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken, tkent, esprehn, adamk
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, zoltan1, dsinclair, sof, eae+blinkwatch, leviw+renderwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, bemjb+rendering_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have HTMLCollection::item() return an Element as per specification Have HTMLCollection::item() return an Element instead of a Node, as per the specification: http://dom.spec.whatwg.org/#htmlcollection This was made possible by adding a NodeType template parameter to the CollectionIndexCache class. Both LiveNodeList and HTMLCollection have a CollectionIndexCache but the former deals with Nodes and the latter deals with Elements. There is no Web-exposed behavior change. This is mostly about using stricter typing on the native side and have our IDL match more closely the specification. This also avoid a few unnecessary isElementNode() checks in our code. R=esprehn, adamk, haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166411

Patch Set 1 #

Patch Set 2 : Small clean up #

Patch Set 3 : Additional clean up~ #

Total comments: 1

Patch Set 4 : Update WebNodeCollection API #

Total comments: 1

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -107 lines) Patch
M Source/bindings/v8/V8WindowShell.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M Source/core/html/CollectionIndexCache.h View 1 2 3 4 10 chunks +23 lines, -23 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 3 4 3 chunks +26 lines, -20 lines 0 comments Download
M Source/core/html/HTMLCollection.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebDocument.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebNodeCollection.cpp View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M public/web/WebNodeCollection.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Inactive
6 years, 10 months ago (2014-02-03 20:02:38 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-03 20:43:33 UTC) #2
Inactive
https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp File Source/web/WebNodeCollection.cpp (right): https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp#newcode75 Source/web/WebNodeCollection.cpp:75: WebNode WebNodeCollection::nextItem() const adamk, what do you think about ...
6 years, 10 months ago (2014-02-03 21:33:08 UTC) #3
Inactive
On 2014/02/03 21:33:08, Chris Dumez wrote: > https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp > File Source/web/WebNodeCollection.cpp (right): > > https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp#newcode75 ...
6 years, 10 months ago (2014-02-03 21:44:54 UTC) #4
Inactive
On 2014/02/03 21:33:08, Chris Dumez wrote: > https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp > File Source/web/WebNodeCollection.cpp (right): > > https://codereview.chromium.org/137433008/diff/120001/Source/web/WebNodeCollection.cpp#newcode75 ...
6 years, 10 months ago (2014-02-03 22:01:36 UTC) #5
Inactive
+tkent for the public API change.
6 years, 10 months ago (2014-02-03 22:02:30 UTC) #6
adamk
Still lgtm, thanks for the API cleanup (but tkent will need to stamp)
6 years, 10 months ago (2014-02-03 22:13:32 UTC) #7
haraken
LGTM
6 years, 10 months ago (2014-02-04 00:58:34 UTC) #8
tkent
lgtm https://codereview.chromium.org/137433008/diff/200001/Source/core/rendering/RenderTheme.cpp File Source/core/rendering/RenderTheme.cpp (right): https://codereview.chromium.org/137433008/diff/200001/Source/core/rendering/RenderTheme.cpp#newcode936 Source/core/rendering/RenderTheme.cpp:936: ASSERT(element->hasTagName(optionTag)); nit: We can remove this assertion because ...
6 years, 10 months ago (2014-02-04 00:59:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137433008/200001
6 years, 10 months ago (2014-02-04 00:59:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 04:17:08 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=25357
6 years, 10 months ago (2014-02-04 04:17:08 UTC) #12
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-02-04 04:20:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137433008/200001
6 years, 10 months ago (2014-02-04 04:20:34 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:49:42 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=25411
6 years, 10 months ago (2014-02-04 06:49:43 UTC) #16
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-04 14:24:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137433008/550001
6 years, 10 months ago (2014-02-04 14:25:10 UTC) #18
commit-bot: I haz the power
Change committed as 166411
6 years, 10 months ago (2014-02-04 16:24:14 UTC) #19
skia-commit-bot
6 years, 10 months ago (2014-02-04 16:24:22 UTC) #20
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698