Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: Source/core/html/HTMLTableRowElement.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.idl ('k') | Source/core/html/HTMLTableSectionElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTableRowElement.cpp
diff --git a/Source/core/html/HTMLTableRowElement.cpp b/Source/core/html/HTMLTableRowElement.cpp
index 7e33eb433e7cbb7f227e5d173b68eb340f45a2a4..c54defc902ea0f18e7e6af14a0c167f43026f63f 100644
--- a/Source/core/html/HTMLTableRowElement.cpp
+++ b/Source/core/html/HTMLTableRowElement.cpp
@@ -142,7 +142,7 @@ void HTMLTableRowElement::deleteCell(int index, ExceptionState& exceptionState)
if (index == -1)
index = numCells-1;
if (index >= 0 && index < numCells) {
- RefPtr<Node> cell = children->item(index);
+ RefPtr<Element> cell = children->item(index);
HTMLElement::removeChild(cell.get(), exceptionState);
} else {
exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(index) + ") is outside the range [0, " + String::number(numCells) + ").");
« no previous file with comments | « Source/core/html/HTMLSelectElement.idl ('k') | Source/core/html/HTMLTableSectionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698