Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: Source/web/WebNodeCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "WebNodeCollection.h" 32 #include "WebNodeCollection.h"
33 33
34 #include "WebElement.h"
34 #include "core/dom/Node.h" 35 #include "core/dom/Node.h"
35 #include "core/html/HTMLCollection.h" 36 #include "core/html/HTMLCollection.h"
36 #include "wtf/PassRefPtr.h" 37 #include "wtf/PassRefPtr.h"
37 38
38 #include "WebNode.h"
39
40 using namespace WebCore; 39 using namespace WebCore;
41 40
42 namespace blink { 41 namespace blink {
43 42
44 void WebNodeCollection::reset() 43 void WebNodeCollection::reset()
45 { 44 {
46 assign(0); 45 assign(0);
47 } 46 }
48 47
49 void WebNodeCollection::assign(const WebNodeCollection& other) 48 void WebNodeCollection::assign(const WebNodeCollection& other)
(...skipping 15 matching lines...) Expand all
65 if (m_private) 64 if (m_private)
66 m_private->deref(); 65 m_private->deref();
67 m_private = p; 66 m_private = p;
68 } 67 }
69 68
70 unsigned WebNodeCollection::length() const 69 unsigned WebNodeCollection::length() const
71 { 70 {
72 return m_private->length(); 71 return m_private->length();
73 } 72 }
74 73
75 WebNode WebNodeCollection::nextItem() const 74 WebElement WebNodeCollection::nextItem() const
76 { 75 {
77 Node* node = m_private->item(m_current); 76 Element* element = m_private->item(m_current);
78 if (node) 77 if (element)
79 m_current++; 78 m_current++;
80 return WebNode(node); 79 return WebElement(element);
81 } 80 }
82 81
83 WebNode WebNodeCollection::firstItem() const 82 WebElement WebNodeCollection::firstItem() const
84 { 83 {
85 m_current = 0; 84 m_current = 0;
86 return nextItem(); 85 return nextItem();
87 } 86 }
88 87
89 } // namespace blink 88 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698