Source/core/html/HTMLAllCollection.idl - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAllCollection.idl

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAllCollection.idl

diff --git a/Source/core/html/HTMLAllCollection.idl b/Source/core/html/HTMLAllCollection.idl

index 9193c7239e8cc3c4349cac991dbf60f6ff427127..fcc8d7890184eefaf0e22da1796ffe8832507a8e 100644

--- a/Source/core/html/HTMLAllCollection.idl

+++ b/Source/core/html/HTMLAllCollection.idl

@@ -29,8 +29,8 @@

SetWrapperReferenceFrom=ownerNode,

] interface HTMLAllCollection {

readonly attribute unsigned long length;

- [ImplementedAs=item] getter Node (unsigned long index);

- [Custom] Node item([Default=Undefined] optional unsigned long index);

+ [ImplementedAs=item] getter Element (unsigned long index);

+ [Custom] Element item([Default=Undefined] optional unsigned long index);

[NotEnumerable] getter (NodeList or Element) (DOMString name);

[Custom] Element namedItem(DOMString name);

// FIXME: This should return an HTMLAllCollection.

« no previous file with comments | « Source/core/html/HTMLAllCollection.cpp ('k') | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »