Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2416)

Unified Diff: Source/web/WebPageSerializerImpl.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPageSerializer.cpp ('k') | public/web/WebNodeCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPageSerializerImpl.cpp
diff --git a/Source/web/WebPageSerializerImpl.cpp b/Source/web/WebPageSerializerImpl.cpp
index 4eed2f03b7f7f8646c70b5a22c6370b4b4d6ffad..a2b7705831973b07453dac353a514cc0ede8cf3b 100644
--- a/Source/web/WebPageSerializerImpl.cpp
+++ b/Source/web/WebPageSerializerImpl.cpp
@@ -477,10 +477,9 @@ void WebPageSerializerImpl::collectTargetFrames()
// Go through sub-frames.
RefPtr<HTMLCollection> all = currentDoc->all();
- for (unsigned i = 0; Node* node = all->item(i); i++) {
- if (!node->isHTMLElement())
+ for (unsigned i = 0; Element* element = all->item(i); i++) {
+ if (!element->isHTMLElement())
continue;
- Element* element = toElement(node);
WebFrameImpl* webFrame =
WebFrameImpl::fromFrameOwnerElement(element);
if (webFrame)
« no previous file with comments | « Source/web/WebPageSerializer.cpp ('k') | public/web/WebNodeCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698