Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: Source/web/WebNodeCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Additional clean up~ Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 if (m_private) 65 if (m_private)
66 m_private->deref(); 66 m_private->deref();
67 m_private = p; 67 m_private = p;
68 } 68 }
69 69
70 unsigned WebNodeCollection::length() const 70 unsigned WebNodeCollection::length() const
71 { 71 {
72 return m_private->length(); 72 return m_private->length();
73 } 73 }
74 74
75 WebNode WebNodeCollection::nextItem() const 75 WebNode WebNodeCollection::nextItem() const
Inactive 2014/02/03 21:33:09 adamk, what do you think about updating nextItem()
76 { 76 {
77 Node* node = m_private->item(m_current); 77 Element* element = m_private->item(m_current);
78 if (node) 78 if (element)
79 m_current++; 79 m_current++;
80 return WebNode(node); 80 return WebNode(element);
81 } 81 }
82 82
83 WebNode WebNodeCollection::firstItem() const 83 WebNode WebNodeCollection::firstItem() const
84 { 84 {
85 m_current = 0; 85 m_current = 0;
86 return nextItem(); 86 return nextItem();
87 } 87 }
88 88
89 } // namespace blink 89 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698